public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Loïc Minier" <lool@dooz.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Use sizeof(gd_t), not sizeof(struct global_data)
Date: Mon, 3 Jan 2011 18:03:08 +0100	[thread overview]
Message-ID: <20110103170308.GC10571@bee.dooz.org> (raw)
In-Reply-To: <20110103165146.395B0CEF7A6@gemini.denx.de>

On Mon, Jan 03, 2011, Wolfgang Denk wrote:
> Um... I do not like this change; the resulting code is harder to read.

 I don't mind either way; I had asked
 <20101220111358.GA28532@bee.dooz.org> which one was the preferred
 approach, but didn't get comments on this particular point; see
 <20110103170050.GB10571@bee.dooz.org> for the rationale for picking
 this option rather than the other one.

 I've sent a second patch to also define struct global_data; feel free
 to cherry pick any of the two patches or both

   Thanks!
-- 
Lo?c Minier

  reply	other threads:[~2011-01-03 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 15:47 [U-Boot] [PATCH] Use sizeof(gd_t), not sizeof(struct global_data) Loïc Minier
2011-01-03 16:35 ` Mike Frysinger
2011-01-03 17:00   ` Loïc Minier
2011-01-03 16:51 ` Wolfgang Denk
2011-01-03 17:03   ` Loïc Minier [this message]
2011-01-03 17:00 ` [U-Boot] [PATCH 2/2] i386: Define struct global_data as on other arches Loïc Minier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110103170308.GC10571@bee.dooz.org \
    --to=lool@dooz.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox