From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: ns16550: fix different reg size access
Date: Thu, 31 Mar 2011 17:58:51 +0200 [thread overview]
Message-ID: <20110331155851.BA1F1F03209@gemini.denx.de> (raw)
In-Reply-To: <1301586774-25447-1-git-send-email-leiwen@marvell.com>
Dear Lei Wen,
In message <1301586774-25447-1-git-send-email-leiwen@marvell.com> you wrote:
> Some hardware would dysfunctional if only access the register by
> byte. This patch is tend to recover original access the responding
> register according to CONFIG_SYS_NS16550_REG_SIZE.
Can you please explain on what board, and with which tool chain, you
see any problems?
> +- CONFIG_SYS_NS16550_MAX_REG_SIZE:
> + Define the ns16550 max register size,
> + if the CONFIG_SYS_NS16550_REG_SIZE is smaller than this value,
> + use padding to fill those gap.
This makes no sense to me. A register is always one specific size,
so the term "MAX_REG_SIZE" is bogus.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Landru! Guide us!
-- A Beta 3-oid, "The Return of the Archons", stardate 3157.4
next prev parent reply other threads:[~2011-03-31 15:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 15:52 [U-Boot] [PATCH] serial: ns16550: fix different reg size access Lei Wen
2011-03-31 15:58 ` Wolfgang Denk [this message]
2011-04-01 5:24 ` Lei Wen
2011-04-01 5:35 ` Wolfgang Denk
2011-04-01 5:39 ` Lei Wen
2011-04-01 7:39 ` Wolfgang Denk
2011-04-01 7:59 ` Lei Wen
2011-04-01 10:25 ` Wolfgang Denk
2011-04-01 12:03 ` Lei Wen
2011-04-01 12:41 ` Wolfgang Denk
2011-04-01 13:07 ` Lei Wen
2011-04-01 13:55 ` Wolfgang Denk
2011-04-01 13:58 ` Lei Wen
2011-04-01 14:25 ` Wolfgang Denk
2011-04-01 14:34 ` Lei Wen
2011-04-01 17:45 ` Wolfgang Denk
2011-04-01 18:59 ` Prafulla Wadaskar
2011-04-01 19:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331155851.BA1F1F03209@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox