public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Add assert() for debug assertions
Date: Sat, 10 Sep 2011 00:04:10 +0200	[thread overview]
Message-ID: <20110909220410.4935D140876B@gemini.denx.de> (raw)
In-Reply-To: <1309376974-12943-1-git-send-email-sjg@chromium.org>

Dear Simon Glass,

In message <1309376974-12943-1-git-send-email-sjg@chromium.org> you wrote:
> assert() is like BUG_ON() but compiles to nothing unless DEBUG is defined.
> This is useful when a condition is an error but a board reset is unlikely
> to fix it, so it is better to soldier on in hope. Assertion failures should
> be caught during development/test.
> 
> It turns out that assert() is defined separately in a few places in U-Boot
> with various meanings. This patch cleans up some of these.
> 
> Build errors exposed by this change (and defining DEBUG) are also fixed in
> this patch.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Changed macros so that all code is compiled even if DEBUG is disabled
> 
> Changes in v3:
> - Use panic() instead of printf()
> - Use separate __assert_fail() function to reduce memory footprint
> - Changed output format to match assert(3)
> 
>  common/dlmalloc.c |    7 -------
>  include/common.h  |   21 +++++++++++++++++++++
>  include/malloc.h  |    8 --------
>  lib/qsort.c       |    5 -----
>  lib/vsprintf.c    |    8 ++++++++
>  5 files changed, 29 insertions(+), 20 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?

  parent reply	other threads:[~2011-09-09 22:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 19:49 [U-Boot] [PATCH v3] Add assert() for debug assertions Simon Glass
2011-06-29 20:43 ` Mike Frysinger
2011-06-29 21:01   ` Wolfgang Denk
2011-06-29 21:54     ` Mike Frysinger
2011-09-07 22:29       ` Simon Glass
2011-09-09  0:34         ` Mike Frysinger
2011-09-09 13:55           ` Simon Glass
2011-09-09 22:04 ` Wolfgang Denk [this message]
2011-09-09 22:38 ` [U-Boot] [PATCH] Fix warning: "assert" redefined Wolfgang Denk
2011-09-09 22:46   ` Simon Glass
2011-09-10 20:37   ` Wolfgang Denk
2011-09-10 14:07 ` [U-Boot] [PATCH] utx8245: fix build breakage due to assert() Wolfgang Denk
2011-09-10 20:42   ` Wolfgang Denk
2011-09-10 14:19 ` [U-Boot] [PATCH] tegra2: fix warning: "assert" redefined Wolfgang Denk
2011-09-10 20:44   ` Wolfgang Denk
2011-09-12  4:39     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110909220410.4935D140876B@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox