From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot
Date: Mon, 16 Jan 2012 09:19:34 +0100 [thread overview]
Message-ID: <20120116081934.7BDF117133E2@gemini.denx.de> (raw)
In-Reply-To: <1326656467.18981.225.camel@keto>
Dear Stephan Linz,
In message <1326656467.18981.225.camel@keto> you wrote:
>
> OK, I'll try to change the buffer handling as soon as possible in one of
> the next optimization stages of this driver. Looks interesting and
> important to me ...
...
> The alignment is essential for the LL TEMAC driver, especially the 32
> byte alignment. I look to continue to optimize this part after the patch
> has been added.
No, please do it now. I will not pull the current patch.
> > or do it now and re-submit a v2 ...
>
> I have already done. Patch is coming up ... :-)
No, you misunderstant. You submitted an incremental, separate patch.
But we don't want to add code that is known to have problems /
shortcomings now and fix / improve it 5 minutes later. We let the
patch ripe and add it only when we consider it ready.
So please do not defer weorkign on the review comments.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Look! There! Evil!.. pure and simple, total evil from the Eighth
Dimension!" - Buckaroo Banzai
next prev parent reply other threads:[~2012-01-16 8:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 15:41 [U-Boot] LL TEMAC V8 refactored Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot Stephan Linz
2012-01-15 17:28 ` Mike Frysinger
2012-01-15 18:29 ` Stephan Linz
2012-01-15 18:47 ` Mike Frysinger
2012-01-15 19:41 ` Stephan Linz
2012-01-16 8:19 ` Wolfgang Denk [this message]
2012-01-17 20:19 ` Stephan Linz
2012-01-16 8:14 ` Wolfgang Denk
2012-01-16 17:46 ` Stephan Linz
2012-01-15 19:46 ` [U-Boot] [PATCH] net: ll_temac: Remove useless memory erasing Stephan Linz
2012-01-15 23:44 ` Mike Frysinger
2012-01-16 17:22 ` Stephan Linz
2012-01-16 8:06 ` Wolfgang Denk
2012-01-15 15:46 ` [U-Boot] [PATCH 2/5] microblaze: Enable several ethernet driver compilation Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 3/5] microblaze: Wire up LL_TEMAC driver initialization Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 4/5] microblaze: Enable phylib and mii support Stephan Linz
2012-01-15 15:46 ` [U-Boot] [PATCH 5/5] microblaze: Add faked LL_TEMAC driver configuration Stephan Linz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116081934.7BDF117133E2@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox