From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: mxs: Allow other chip selects to work
Date: Mon, 23 Apr 2012 13:43:27 -0400 [thread overview]
Message-ID: <201204231343.28756.vapier@gentoo.org> (raw)
In-Reply-To: <1335184992-2381-1-git-send-email-fabio.estevam@freescale.com>
On Monday 23 April 2012 08:43:12 Fabio Estevam wrote:
> --- a/drivers/spi/mxs_spi.c
> +++ b/drivers/spi/mxs_spi.c
> @@ -56,12 +58,19 @@ struct spi_slave *spi_setup_slave(unsigned int bus,
>
> if (bus > 3) {
> printf("MXS SPI: Max bus number is 3\n");
> return NULL;
> }
>
> + if (cs > 2) {
> + printf("MXS SPI: Invalid chip select number: %d\n", cs);
> + return NULL;
> + }
this stuff really belongs in spi_cs_is_valid(), sans the printf's.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120423/10aed766/attachment.pgp>
prev parent reply other threads:[~2012-04-23 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 12:43 [U-Boot] [PATCH] spi: mxs: Allow other chip selects to work Fabio Estevam
2012-04-23 13:12 ` Marek Vasut
2012-04-23 17:43 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204231343.28756.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox