public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: mxs: Allow other chip selects to work
Date: Mon, 23 Apr 2012 15:12:38 +0200	[thread overview]
Message-ID: <201204231512.39143.marex@denx.de> (raw)
In-Reply-To: <1335184992-2381-1-git-send-email-fabio.estevam@freescale.com>

Dear Fabio Estevam,

> MXS SSP controller may have up to three chip selects per port: SS0, SS1 and
> SS2.
> 
> Currently only SS0 is supported in the mxs_spi driver.
> 
> Allow all the three chip select to work by selecting the desired one
> in bits 20 and 21 of the HW_SSP_CTRL0 register.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/spi/mxs_spi.c |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
> index 4e6f14e..c0bfd25 100644
> --- a/drivers/spi/mxs_spi.c
> +++ b/drivers/spi/mxs_spi.c
> @@ -34,6 +34,8 @@
> 
>  #define	MXS_SPI_MAX_TIMEOUT	1000000
>  #define	MXS_SPI_PORT_OFFSET	0x2000
> +#define MXS_SSP_CHIPSELECT_MASK		0x00300000
> +#define MXS_SSP_CHIPSELECT_SHIFT	20
> 
>  struct mxs_spi_slave {
>  	struct spi_slave	slave;
> @@ -56,12 +58,19 @@ struct spi_slave *spi_setup_slave(unsigned int bus,
> unsigned int cs, {
>  	struct mxs_spi_slave *mxs_slave;
>  	uint32_t addr;
> +	struct mx28_ssp_regs *ssp_regs;
> +	int reg;
> 
>  	if (bus > 3) {
>  		printf("MXS SPI: Max bus number is 3\n");
>  		return NULL;
>  	}
> 
> +	if (cs > 2) {
> +		printf("MXS SPI: Invalid chip select number: %d\n", cs);
> +		return NULL;
> +	}
> +
>  	mxs_slave = malloc(sizeof(struct mxs_spi_slave));
>  	if (!mxs_slave)
>  		return NULL;
> @@ -74,6 +83,14 @@ struct spi_slave *spi_setup_slave(unsigned int bus,
> unsigned int cs, mxs_slave->mode = mode;
>  	mxs_slave->regs = (struct mx28_ssp_regs *)addr;
> 
> +	ssp_regs = mxs_slave->regs;
> +
> +	reg = readl(&ssp_regs->hw_ssp_ctrl0);
> +	reg &= ~(MXS_SSP_CHIPSELECT_MASK);
> +	reg |= cs << MXS_SSP_CHIPSELECT_SHIFT;
> +
> +	writel(reg, &ssp_regs->hw_ssp_ctrl0);
> +
>  	return &mxs_slave->slave;
>  }

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-23 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 12:43 [U-Boot] [PATCH] spi: mxs: Allow other chip selects to work Fabio Estevam
2012-04-23 13:12 ` Marek Vasut [this message]
2012-04-23 17:43 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204231512.39143.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox