U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] tools/env: Fix build failure from missing header include
@ 2012-10-12 20:23 Joe Hershberger
  2012-10-12 22:20 ` Marek Vasut
  2012-10-15 23:04 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: Joe Hershberger @ 2012-10-12 20:23 UTC (permalink / raw)
  To: u-boot

This was introduced in:
8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
	COMMON: Use __stringify() instead of MK_STR()

The header is now needed since common.h is not included in this tool.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
---
 tools/env/fw_env.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
index 520ce3f..ab8c15d 100644
--- a/tools/env/fw_env.c
+++ b/tools/env/fw_env.c
@@ -26,6 +26,7 @@
 
 #include <errno.h>
 #include <fcntl.h>
+#include <linux/stringify.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stddef.h>
-- 
1.7.11.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] tools/env: Fix build failure from missing header include
  2012-10-12 20:23 [U-Boot] [PATCH] tools/env: Fix build failure from missing header include Joe Hershberger
@ 2012-10-12 22:20 ` Marek Vasut
  2012-10-13  3:55   ` Joe Hershberger
  2012-10-15 23:04 ` [U-Boot] " Tom Rini
  1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2012-10-12 22:20 UTC (permalink / raw)
  To: u-boot

Dear Joe Hershberger,

> This was introduced in:
> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
> 	COMMON: Use __stringify() instead of MK_STR()
> 
> The header is now needed since common.h is not included in this tool.

Good find. This is -next, right ?

> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
>  tools/env/fw_env.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> index 520ce3f..ab8c15d 100644
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> @@ -26,6 +26,7 @@
> 
>  #include <errno.h>
>  #include <fcntl.h>
> +#include <linux/stringify.h>
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <stddef.h>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] tools/env: Fix build failure from missing header include
  2012-10-12 22:20 ` Marek Vasut
@ 2012-10-13  3:55   ` Joe Hershberger
  0 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2012-10-13  3:55 UTC (permalink / raw)
  To: u-boot

Hi Marek,

On Fri, Oct 12, 2012 at 5:20 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Joe Hershberger,
>
>> This was introduced in:
>> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
>>       COMMON: Use __stringify() instead of MK_STR()
>>
>> The header is now needed since common.h is not included in this tool.
>
> Good find. This is -next, right ?

Correct... this is based on -next.

-Joe

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] tools/env: Fix build failure from missing header include
  2012-10-12 20:23 [U-Boot] [PATCH] tools/env: Fix build failure from missing header include Joe Hershberger
  2012-10-12 22:20 ` Marek Vasut
@ 2012-10-15 23:04 ` Tom Rini
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2012-10-15 23:04 UTC (permalink / raw)
  To: u-boot

On Fri, Oct 12, 2012 at 10:23:37AM -0000, Joe Hershberger wrote:

> This was introduced in:
> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
> 	COMMON: Use __stringify() instead of MK_STR()
> 
> The header is now needed since common.h is not included in this tool.
> 
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121015/3aae4ae6/attachment.pgp>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-10-15 23:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-12 20:23 [U-Boot] [PATCH] tools/env: Fix build failure from missing header include Joe Hershberger
2012-10-12 22:20 ` Marek Vasut
2012-10-13  3:55   ` Joe Hershberger
2012-10-15 23:04 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox