From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] dfu: Fix crash when wrong number of arguments given
Date: Fri, 30 Nov 2012 18:10:30 +0100 [thread overview]
Message-ID: <20121130181030.04d9b7b5@amdc308.digital.local> (raw)
In-Reply-To: <1354294293-2801-6-git-send-email-panto@antoniou-consulting.com>
Hi Pantelis,
> Fix obvious crash when not enough arguments are given to the dfu
> command.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> common/cmd_dfu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
> index 327c738..83ef324 100644
> --- a/common/cmd_dfu.c
> +++ b/common/cmd_dfu.c
> @@ -50,7 +50,7 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int
> argc, char * const argv[]) if (ret)
> return CMD_RET_FAILURE;
>
> - if (strcmp(argv[3], "list") == 0) {
> + if (argc > 3 && strcmp(argv[3], "list") == 0) {
> dfu_show_entities();
> goto done;
> }
Why do you don't include changelog for your patches?
This is already v3, and I had comment to this patch in v2.
Unfortunately with no feedback from your side.
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center | Linux Platform Group
next prev parent reply other threads:[~2012-11-30 17:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 16:51 [U-Boot] [PATCH 0/9] USB: Gadget & DFU related fixes (v3) Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 1/9] usb: Fix bug when both DFU & ETHER are defined Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 2/9] g_dnl: Issue connect/disconnect as appropriate Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 3/9] g_dnl: Properly terminate string list Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 4/9] dfu: Only perform DFU board_usb_init() for TRATS Pantelis Antoniou
2012-11-30 17:08 ` Lukasz Majewski
2012-11-30 16:51 ` [U-Boot] [PATCH 5/9] dfu: Fix crash when wrong number of arguments given Pantelis Antoniou
2012-11-30 17:10 ` Lukasz Majewski [this message]
2012-11-30 16:51 ` [U-Boot] [PATCH 6/9] dfu: Send correct DFU response from composite_setup Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 7/9] dfu: Properly zero out timeout value Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 8/9] dfu: Add a partition type target Pantelis Antoniou
2012-11-30 16:51 ` [U-Boot] [PATCH 9/9] dfu: Support larger than memory transfers Pantelis Antoniou
2013-01-03 8:30 ` kasim ling
2013-01-04 17:23 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130181030.04d9b7b5@amdc308.digital.local \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox