* [U-Boot] [PATCH 1/2] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set
@ 2013-01-27 21:53 Otavio Salvador
2013-01-27 21:53 ` [U-Boot] [PATCH 2/2] mx23_olinuxino: Add support for status LED Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: Otavio Salvador @ 2013-01-27 21:53 UTC (permalink / raw)
To: u-boot
This fixes the gpio_led driver which needs to compare againt a
STATUS_LED_ON to enable a led.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
common/cmd_led.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/cmd_led.c b/common/cmd_led.c
index 7f5ab43..84f79fa 100644
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -110,13 +110,15 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (led_commands[i].on)
led_commands[i].on();
else
- __led_set(led_commands[i].mask, 1);
+ __led_set(led_commands[i].mask,
+ STATUS_LED_ON);
break;
case LED_OFF:
if (led_commands[i].off)
led_commands[i].off();
else
- __led_set(led_commands[i].mask, 0);
+ __led_set(led_commands[i].mask,
+ STATUS_LED_OFF);
break;
case LED_TOGGLE:
if (led_commands[i].toggle)
--
1.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 2/2] mx23_olinuxino: Add support for status LED
2013-01-27 21:53 [U-Boot] [PATCH 1/2] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
@ 2013-01-27 21:53 ` Otavio Salvador
2013-01-27 21:52 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Otavio Salvador @ 2013-01-27 21:53 UTC (permalink / raw)
To: u-boot
This allow user to know if the bootloader is running, even without a
serial console.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 +++++++
board/olimex/mx23_olinuxino/spl_boot.c | 4 ++++
include/configs/mx23_olinuxino.h | 12 ++++++++++++
3 files changed, 23 insertions(+)
diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
index 6a6053b..2501417 100644
--- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
+++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
@@ -28,6 +28,9 @@
#include <asm/arch/imx-regs.h>
#include <asm/arch/clock.h>
#include <asm/arch/sys_proto.h>
+#ifdef CONFIG_STATUS_LED
+#include <status_led.h>
+#endif
DECLARE_GLOBAL_DATA_PTR;
@@ -67,5 +70,9 @@ int board_init(void)
/* Adress of boot parameters */
gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
+#if defined(CONFIG_STATUS_LED) && defined(STATUS_LED_BOOT)
+ status_led_set(STATUS_LED_BOOT, STATUS_LED_STATE);
+#endif
+
return 0;
}
diff --git a/board/olimex/mx23_olinuxino/spl_boot.c b/board/olimex/mx23_olinuxino/spl_boot.c
index 7def8bc..ed8f8d9 100644
--- a/board/olimex/mx23_olinuxino/spl_boot.c
+++ b/board/olimex/mx23_olinuxino/spl_boot.c
@@ -84,6 +84,10 @@ const iomux_cfg_t iomux_setup[] = {
MX23_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
MX23_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
+ /* Green LED */
+ MX23_PAD_SSP1_DETECT__GPIO_2_1 |
+ (MXS_PAD_4MA | MXS_PAD_3V3),
+
/* MMC 0 */
MX23_PAD_SSP1_CMD__SSP1_CMD | MUX_CONFIG_SSP,
MX23_PAD_SSP1_DATA0__SSP1_DATA0 | MUX_CONFIG_SSP,
diff --git a/include/configs/mx23_olinuxino.h b/include/configs/mx23_olinuxino.h
index 4658aea..c57bb67 100644
--- a/include/configs/mx23_olinuxino.h
+++ b/include/configs/mx23_olinuxino.h
@@ -56,6 +56,7 @@
#define CONFIG_CMD_EXT2
#define CONFIG_CMD_FAT
#define CONFIG_CMD_GPIO
+#define CONFIG_CMD_LED
#define CONFIG_CMD_MMC
/*
@@ -112,6 +113,17 @@
#define CONFIG_BAUDRATE 115200 /* Default baud rate */
/*
+ * Status LED
+ */
+#define CONFIG_STATUS_LED
+#define CONFIG_GPIO_LED
+#define CONFIG_BOARD_SPECIFIC_LED
+#define STATUS_LED_BOOT 0
+#define STATUS_LED_BIT 0x30a
+#define STATUS_LED_STATE STATUS_LED_ON
+#define STATUS_LED_PERIOD (CONFIG_SYS_HZ / 2)
+
+/*
* MMC Driver
*/
#ifdef CONFIG_CMD_MMC
--
1.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] mx23_olinuxino: Add support for status LED
2013-01-27 21:53 ` [U-Boot] [PATCH 2/2] mx23_olinuxino: Add support for status LED Otavio Salvador
@ 2013-01-27 21:52 ` Marek Vasut
2013-01-27 22:03 ` Otavio Salvador
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2013-01-27 21:52 UTC (permalink / raw)
To: u-boot
Dear Otavio Salvador,
> This allow user to know if the bootloader is running, even without a
> serial console.
1/2 is missing ?
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 +++++++
> board/olimex/mx23_olinuxino/spl_boot.c | 4 ++++
> include/configs/mx23_olinuxino.h | 12 ++++++++++++
> 3 files changed, 23 insertions(+)
>
> diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
> b/board/olimex/mx23_olinuxino/mx23_olinuxino.c index 6a6053b..2501417
> 100644
> --- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
> +++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
> @@ -28,6 +28,9 @@
> #include <asm/arch/imx-regs.h>
> #include <asm/arch/clock.h>
> #include <asm/arch/sys_proto.h>
> +#ifdef CONFIG_STATUS_LED
> +#include <status_led.h>
> +#endif
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -67,5 +70,9 @@ int board_init(void)
> /* Adress of boot parameters */
> gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>
> +#if defined(CONFIG_STATUS_LED) && defined(STATUS_LED_BOOT)
> + status_led_set(STATUS_LED_BOOT, STATUS_LED_STATE);
> +#endif
> +
> return 0;
> }
I'm missing LED value setter ... so the LED toggles only because you set the
pinmux, right ?
> diff --git a/board/olimex/mx23_olinuxino/spl_boot.c
> b/board/olimex/mx23_olinuxino/spl_boot.c index 7def8bc..ed8f8d9 100644
> --- a/board/olimex/mx23_olinuxino/spl_boot.c
> +++ b/board/olimex/mx23_olinuxino/spl_boot.c
> @@ -84,6 +84,10 @@ const iomux_cfg_t iomux_setup[] = {
> MX23_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
> MX23_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
>
> + /* Green LED */
> + MX23_PAD_SSP1_DETECT__GPIO_2_1 |
> + (MXS_PAD_4MA | MXS_PAD_3V3),
NOPULL ?
> /* MMC 0 */
> MX23_PAD_SSP1_CMD__SSP1_CMD | MUX_CONFIG_SSP,
> MX23_PAD_SSP1_DATA0__SSP1_DATA0 | MUX_CONFIG_SSP,
> diff --git a/include/configs/mx23_olinuxino.h
> b/include/configs/mx23_olinuxino.h index 4658aea..c57bb67 100644
> --- a/include/configs/mx23_olinuxino.h
> +++ b/include/configs/mx23_olinuxino.h
> @@ -56,6 +56,7 @@
> #define CONFIG_CMD_EXT2
> #define CONFIG_CMD_FAT
> #define CONFIG_CMD_GPIO
> +#define CONFIG_CMD_LED
> #define CONFIG_CMD_MMC
>
> /*
> @@ -112,6 +113,17 @@
> #define CONFIG_BAUDRATE 115200 /* Default baud rate */
>
> /*
> + * Status LED
> + */
> +#define CONFIG_STATUS_LED
> +#define CONFIG_GPIO_LED
> +#define CONFIG_BOARD_SPECIFIC_LED
> +#define STATUS_LED_BOOT 0
> +#define STATUS_LED_BIT 0x30a
> +#define STATUS_LED_STATE STATUS_LED_ON
> +#define STATUS_LED_PERIOD (CONFIG_SYS_HZ / 2)
Are these needed?
> +/*
> * MMC Driver
> */
> #ifdef CONFIG_CMD_MMC
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] mx23_olinuxino: Add support for status LED
2013-01-27 21:52 ` Marek Vasut
@ 2013-01-27 22:03 ` Otavio Salvador
0 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2013-01-27 22:03 UTC (permalink / raw)
To: u-boot
On Sun, Jan 27, 2013 at 7:52 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
>> This allow user to know if the bootloader is running, even without a
>> serial console.
>
> 1/2 is missing ?
No; it is in mailing list but you're not in cc.
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 +++++++
>> board/olimex/mx23_olinuxino/spl_boot.c | 4 ++++
>> include/configs/mx23_olinuxino.h | 12 ++++++++++++
>> 3 files changed, 23 insertions(+)
>>
>> diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>> b/board/olimex/mx23_olinuxino/mx23_olinuxino.c index 6a6053b..2501417
>> 100644
>> --- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>> +++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>> @@ -28,6 +28,9 @@
>> #include <asm/arch/imx-regs.h>
>> #include <asm/arch/clock.h>
>> #include <asm/arch/sys_proto.h>
>> +#ifdef CONFIG_STATUS_LED
>> +#include <status_led.h>
>> +#endif
>>
>> DECLARE_GLOBAL_DATA_PTR;
>>
>> @@ -67,5 +70,9 @@ int board_init(void)
>> /* Adress of boot parameters */
>> gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>>
>> +#if defined(CONFIG_STATUS_LED) && defined(STATUS_LED_BOOT)
>> + status_led_set(STATUS_LED_BOOT, STATUS_LED_STATE);
>> +#endif
>> +
>> return 0;
>> }
>
> I'm missing LED value setter ... so the LED toggles only because you set the
> pinmux, right ?
No; it uses the gpio_led driver so we don't need to write the common code.
>> diff --git a/board/olimex/mx23_olinuxino/spl_boot.c
>> b/board/olimex/mx23_olinuxino/spl_boot.c index 7def8bc..ed8f8d9 100644
>> --- a/board/olimex/mx23_olinuxino/spl_boot.c
>> +++ b/board/olimex/mx23_olinuxino/spl_boot.c
>> @@ -84,6 +84,10 @@ const iomux_cfg_t iomux_setup[] = {
>> MX23_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
>> MX23_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
>>
>> + /* Green LED */
>> + MX23_PAD_SSP1_DETECT__GPIO_2_1 |
>> + (MXS_PAD_4MA | MXS_PAD_3V3),
>
> NOPULL ?
Not needed; removed for v2.
>> /* MMC 0 */
>> MX23_PAD_SSP1_CMD__SSP1_CMD | MUX_CONFIG_SSP,
>> MX23_PAD_SSP1_DATA0__SSP1_DATA0 | MUX_CONFIG_SSP,
>> diff --git a/include/configs/mx23_olinuxino.h
>> b/include/configs/mx23_olinuxino.h index 4658aea..c57bb67 100644
>> --- a/include/configs/mx23_olinuxino.h
>> +++ b/include/configs/mx23_olinuxino.h
>> @@ -56,6 +56,7 @@
>> #define CONFIG_CMD_EXT2
>> #define CONFIG_CMD_FAT
>> #define CONFIG_CMD_GPIO
>> +#define CONFIG_CMD_LED
>> #define CONFIG_CMD_MMC
>>
>> /*
>> @@ -112,6 +113,17 @@
>> #define CONFIG_BAUDRATE 115200 /* Default baud rate */
>>
>> /*
>> + * Status LED
>> + */
>> +#define CONFIG_STATUS_LED
>> +#define CONFIG_GPIO_LED
>> +#define CONFIG_BOARD_SPECIFIC_LED
>> +#define STATUS_LED_BOOT 0
>> +#define STATUS_LED_BIT 0x30a
>> +#define STATUS_LED_STATE STATUS_LED_ON
>> +#define STATUS_LED_PERIOD (CONFIG_SYS_HZ / 2)
>
> Are these needed?
Yes.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-27 22:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-27 21:53 [U-Boot] [PATCH 1/2] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-27 21:53 ` [U-Boot] [PATCH 2/2] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-27 21:52 ` Marek Vasut
2013-01-27 22:03 ` Otavio Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox