From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_mem: Decode the mtest start and end values from fdt
Date: Fri, 1 Mar 2013 14:15:00 -0500 [thread overview]
Message-ID: <20130301191500.GP25797@bill-the-cat> (raw)
In-Reply-To: <20130301160648.CD661200527@gemini.denx.de>
On Fri, Mar 01, 2013 at 05:06:48PM +0100, Wolfgang Denk wrote:
> Dear Jagannadha Sutradharudu Teki,
>
> In message <10597224-d520-4a3f-8185-5de018ee5046@TX2EHSMHS026.ehs.local> you wrote:
> > This patch provides a support to decode the mtest start
> > and end values from fdt config node.
> >
> > Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> > Tested-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> > ---
> > common/cmd_mem.c | 6 ++++--
> > common/main.c | 18 ++++++++++++++++++
> > 2 files changed, 22 insertions(+), 2 deletions(-)
>
> You are adding code here which may bot be user and/or wanted by the
> majority of boards, so please make it configureable (and document the
> new config option).
In addition, if we're going to start whacking around in here, can we
just make this function bail if not passed a start and end address? I'm
a little torn since on the one hand this is a known function, but on the
other it's not something one would expect to be used outside of testing
environments.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130301/634aaf4d/attachment.pgp>
next prev parent reply other threads:[~2013-03-01 19:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 14:32 [U-Boot] [PATCH] cmd_mem: Decode the mtest start and end values from fdt Jagannadha Sutradharudu Teki
2013-03-01 16:06 ` Wolfgang Denk
2013-03-01 19:15 ` Tom Rini [this message]
2013-03-01 19:24 ` Simon Glass
[not found] ` <ff1257d2-b332-477f-915d-0851e5ef944f@CO9EHSMHS030.ehs.local>
2013-03-01 22:48 ` Wolfgang Denk
[not found] ` <51f05678-4118-4be8-bb94-ad295c407602@DB3EHSMHS015.ehs.local>
2013-03-04 9:44 ` Wolfgang Denk
2013-03-08 19:08 ` [U-Boot] [PATCH] Feature Removal: disable "mtest" command by default Wolfgang Denk
2013-03-08 19:41 ` Ira W. Snyder
2013-03-08 20:50 ` Wolfgang Denk
2013-03-08 20:51 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2013-03-11 19:57 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301191500.GP25797@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox