U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] wandboard: fix typo in README
@ 2013-05-13  0:22 Luka Perkov
  0 siblings, 0 replies; 5+ messages in thread
From: Luka Perkov @ 2013-05-13  0:22 UTC (permalink / raw)
  To: u-boot

Fix typo in wandboard README file.

Signed-off-by: Luka Perkov <luka@openwrt.org>
---
 board/wandboard/README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/wandboard/README b/board/wandboard/README
index e0b0b33..ce83bbe 100644
--- a/board/wandboard/README
+++ b/board/wandboard/README
@@ -14,12 +14,12 @@ Building U-boot for Wandboard
 
 To build U-Boot for the Wandboard Dual Lite version:
 
-$ make wanboard_dl_config
+$ make wandboard_dl_config
 $ make
 
 To build U-Boot for the Wandboard Solo version:
 
-$ make wanboard_solo_config
+$ make wandboard_solo_config
 $ make
 
 Flashing U-boot into the SD card
-- 
1.8.2.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] wandboard: Fix typo in README
@ 2013-06-13  3:29 Shigeru Yoshida
  2013-06-13  4:28 ` Wolfgang Denk
  0 siblings, 1 reply; 5+ messages in thread
From: Shigeru Yoshida @ 2013-06-13  3:29 UTC (permalink / raw)
  To: u-boot

Fix configuration make target to use uppercase letters.

Signed-off-by: Shigeru Yoshida <shigeru.yoshida@miraclelinux.com>
---
 board/wandboard/README |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/wandboard/README b/board/wandboard/README
index e0b0b33..8bf646d 100644
--- a/board/wandboard/README
+++ b/board/wandboard/README
@@ -14,12 +14,12 @@ Building U-boot for Wandboard

 To build U-Boot for the Wandboard Dual Lite version:

-$ make wanboard_dl_config
+$ make WANBOARD_DL_config
 $ make

 To build U-Boot for the Wandboard Solo version:

-$ make wanboard_solo_config
+$ make WANBOARD_SOLO_config
 $ make

 Flashing U-boot into the SD card

-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] wandboard: Fix typo in README
  2013-06-13  3:29 [U-Boot] [PATCH] wandboard: Fix " Shigeru Yoshida
@ 2013-06-13  4:28 ` Wolfgang Denk
  2013-06-13 11:40   ` Otavio Salvador
  0 siblings, 1 reply; 5+ messages in thread
From: Wolfgang Denk @ 2013-06-13  4:28 UTC (permalink / raw)
  To: u-boot

Dear Shigeru Yoshida,

In message <CAMQoM_0gL2cZu_Xm-C9_ZONmGmYi1M6W_ysxUv2ETaEbuVRKOg@mail.gmail.com> you wrote:
>
> diff --git a/board/wandboard/README b/board/wandboard/README
> index e0b0b33..8bf646d 100644
> --- a/board/wandboard/README
> +++ b/board/wandboard/README
> @@ -14,12 +14,12 @@ Building U-boot for Wandboard
> 
>  To build U-Boot for the Wandboard Dual Lite version:
> 
> -$ make wanboard_dl_config
> +$ make WANBOARD_DL_config
>  $ make
> 
>  To build U-Boot for the Wandboard Solo version:
> 
> -$ make wanboard_solo_config
> +$ make WANBOARD_SOLO_config
>  $ make

Both "fixes" are wrong.  First, the target names are _really lower
case.  Second, the name is wan>d<board, i. e. you still have the 'd'
missing.  Please change into:

	$ make wandboard_dl_config
resp.
	$ make wandboard_solo_config


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Simplicity boils down to two steps: Identify the essential. Eliminate
the rest.                                               - Leo Babauta

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] wandboard: Fix typo in README
  2013-06-13  4:28 ` Wolfgang Denk
@ 2013-06-13 11:40   ` Otavio Salvador
  2013-06-13 13:39     ` Shigeru Yoshida
  0 siblings, 1 reply; 5+ messages in thread
From: Otavio Salvador @ 2013-06-13 11:40 UTC (permalink / raw)
  To: u-boot

On Thu, Jun 13, 2013 at 1:28 AM, Wolfgang Denk <wd@denx.de> wrote:

> Dear Shigeru Yoshida,
>
> In message <
> CAMQoM_0gL2cZu_Xm-C9_ZONmGmYi1M6W_ysxUv2ETaEbuVRKOg at mail.gmail.com> you
> wrote:
> >
> > diff --git a/board/wandboard/README b/board/wandboard/README
> > index e0b0b33..8bf646d 100644
> > --- a/board/wandboard/README
> > +++ b/board/wandboard/README
> > @@ -14,12 +14,12 @@ Building U-boot for Wandboard
> >
> >  To build U-Boot for the Wandboard Dual Lite version:
> >
> > -$ make wanboard_dl_config
> > +$ make WANBOARD_DL_config
> >  $ make
> >
> >  To build U-Boot for the Wandboard Solo version:
> >
> > -$ make wanboard_solo_config
> > +$ make WANBOARD_SOLO_config
> >  $ make
>
> Both "fixes" are wrong.  First, the target names are _really lower
> case.  Second, the name is wan>d<board, i. e. you still have the 'd'
> missing.  Please change into:
>
>         $ make wandboard_dl_config
> resp.
>         $ make wandboard_solo_config
>

http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=8c4983779ed50090b74d56498be17cde31892a64


Already fixed.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] wandboard: Fix typo in README
  2013-06-13 11:40   ` Otavio Salvador
@ 2013-06-13 13:39     ` Shigeru Yoshida
  0 siblings, 0 replies; 5+ messages in thread
From: Shigeru Yoshida @ 2013-06-13 13:39 UTC (permalink / raw)
  To: u-boot

2013/6/13 Otavio Salvador <otavio@ossystems.com.br>

>
>
> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=8c4983779ed50090b74d56498be17cde31892a64
>
>
> Already fixed.
>

This patch worked my environment.
Thank you!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-06-13 13:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-13  0:22 [U-Boot] [PATCH] wandboard: fix typo in README Luka Perkov
  -- strict thread matches above, loose matches on Subject: below --
2013-06-13  3:29 [U-Boot] [PATCH] wandboard: Fix " Shigeru Yoshida
2013-06-13  4:28 ` Wolfgang Denk
2013-06-13 11:40   ` Otavio Salvador
2013-06-13 13:39     ` Shigeru Yoshida

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox