* [U-Boot] [PATCH] Makefile: fix the typo error for mrproper
@ 2013-12-16 7:27 Bo Shen
2013-12-16 15:53 ` Simon Glass
2013-12-19 17:43 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Bo Shen @ 2013-12-16 7:27 UTC (permalink / raw)
To: u-boot
Fix the typo error for mrproper from mkproper.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
In Makefile, there is no object name is mkproper, so I think this is
a typo error.
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 7310c4e..ddbaaf0 100644
--- a/Makefile
+++ b/Makefile
@@ -168,7 +168,7 @@ endif
include $(TOPDIR)/config.mk
# Targets which don't build the source code
-NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
+NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
# Only do the generic board check when actually building, not configuring
ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Makefile: fix the typo error for mrproper
2013-12-16 7:27 [U-Boot] [PATCH] Makefile: fix the typo error for mrproper Bo Shen
@ 2013-12-16 15:53 ` Simon Glass
2013-12-16 16:38 ` Tom Rini
2013-12-19 17:43 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 5+ messages in thread
From: Simon Glass @ 2013-12-16 15:53 UTC (permalink / raw)
To: u-boot
On 16 December 2013 00:27, Bo Shen <voice.shen@atmel.com> wrote:
> Fix the typo error for mrproper from mkproper.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
Adding Masahiro.
> ---
> In Makefile, there is no object name is mkproper, so I think this is
> a typo error.
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 7310c4e..ddbaaf0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -168,7 +168,7 @@ endif
> include $(TOPDIR)/config.mk
>
> # Targets which don't build the source code
> -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
> +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
>
> # Only do the generic board check when actually building, not configuring
> ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Makefile: fix the typo error for mrproper
2013-12-16 15:53 ` Simon Glass
@ 2013-12-16 16:38 ` Tom Rini
2013-12-16 17:06 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2013-12-16 16:38 UTC (permalink / raw)
To: u-boot
On Mon, Dec 16, 2013 at 08:53:08AM -0700, Simon Glass wrote:
> On 16 December 2013 00:27, Bo Shen <voice.shen@atmel.com> wrote:
> > Fix the typo error for mrproper from mkproper.
> >
> > Signed-off-by: Bo Shen <voice.shen@atmel.com>
>
> Adding Masahiro.
>
> > ---
> > In Makefile, there is no object name is mkproper, so I think this is
> > a typo error.
> >
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 7310c4e..ddbaaf0 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -168,7 +168,7 @@ endif
> > include $(TOPDIR)/config.mk
> >
> > # Targets which don't build the source code
> > -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
> > +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
> >
> > # Only do the generic board check when actually building, not configuring
> > ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
Note all of this logic came in with fada9e2 which is you, Simon :) But
I'm pretty sure this is trivially correct, so I'll take it soon.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131216/bf88d000/attachment.pgp>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Makefile: fix the typo error for mrproper
2013-12-16 16:38 ` Tom Rini
@ 2013-12-16 17:06 ` Simon Glass
0 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2013-12-16 17:06 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 16 December 2013 09:38, Tom Rini <trini@ti.com> wrote:
> On Mon, Dec 16, 2013 at 08:53:08AM -0700, Simon Glass wrote:
>> On 16 December 2013 00:27, Bo Shen <voice.shen@atmel.com> wrote:
>> > Fix the typo error for mrproper from mkproper.
>> >
>> > Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>
>> Adding Masahiro.
>>
>> > ---
>> > In Makefile, there is no object name is mkproper, so I think this is
>> > a typo error.
>> >
>> > Makefile | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Makefile b/Makefile
>> > index 7310c4e..ddbaaf0 100644
>> > --- a/Makefile
>> > +++ b/Makefile
>> > @@ -168,7 +168,7 @@ endif
>> > include $(TOPDIR)/config.mk
>> >
>> > # Targets which don't build the source code
>> > -NON_BUILD_TARGETS = backup clean clobber distclean mkproper tidy unconfig
>> > +NON_BUILD_TARGETS = backup clean clobber distclean mrproper tidy unconfig
>> >
>> > # Only do the generic board check when actually building, not configuring
>> > ifeq ($(filter $(NON_BUILD_TARGETS),$(MAKECMDGOALS)),)
>
> Note all of this logic came in with fada9e2 which is you, Simon :) But
> I'm pretty sure this is trivially correct, so I'll take it soon.
OK, I see. Yes looks right.
Acked-by: Simon Glass <sjg@chromium.org>
Regards,
Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] Makefile: fix the typo error for mrproper
2013-12-16 7:27 [U-Boot] [PATCH] Makefile: fix the typo error for mrproper Bo Shen
2013-12-16 15:53 ` Simon Glass
@ 2013-12-19 17:43 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2013-12-19 17:43 UTC (permalink / raw)
To: u-boot
On Mon, Dec 16, 2013 at 03:27:23PM +0800, Bo Shen wrote:
> Fix the typo error for mrproper from mkproper.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131219/d4885c5a/attachment.pgp>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-19 17:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 7:27 [U-Boot] [PATCH] Makefile: fix the typo error for mrproper Bo Shen
2013-12-16 15:53 ` Simon Glass
2013-12-16 16:38 ` Tom Rini
2013-12-16 17:06 ` Simon Glass
2013-12-19 17:43 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox