From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3] board_r - fixup functions table after relocation
Date: Mon, 27 Jan 2014 09:57:09 -0500 [thread overview]
Message-ID: <20140127145709.GI3277@bill-the-cat> (raw)
In-Reply-To: <1390213839-14018-1-git-send-email-abrodkin@synopsys.com>
On Mon, Jan 20, 2014 at 02:30:39PM +0400, Alexey Brodkin wrote:
> This is only required for "PIC" relocation and doesn't apply to modern
> "PIE" relocation which does data relocation as well as code.
>
> "init_sequence_r" is just an array that consists of compile-time
> adresses of init functions. Since this is basically an array of integers
> (pointers to "void" to be more precise) it won't be modified during
> relocation - it will be just copied to new location as it is.
>
> As a consequence on execution after relocation "initcall_run_list" will
> be jumping to pre-relocation addresses. As long as we don't overwrite
> pre-relocation memory area init calls are executed correctly. But still
> it is dangerous because after relocation we don't expect initially used
> memory to stay untouched.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Thomas Langer <thomas.langer@lantiq.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140127/2deb1dc2/attachment.pgp>
prev parent reply other threads:[~2014-01-27 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 10:30 [U-Boot] [PATCH v3] board_r - fixup functions table after relocation Alexey Brodkin
2014-01-21 16:13 ` Simon Glass
2014-01-21 16:39 ` Alexey Brodkin
2014-01-27 14:57 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127145709.GI3277@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox