From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] part_efi: fix protective mbr struct allocation
Date: Mon, 24 Feb 2014 10:52:44 -0500 [thread overview]
Message-ID: <20140224155244.GO16805@bill-the-cat> (raw)
In-Reply-To: <20140224164605.57ab248b@amdc2363>
On Mon, Feb 24, 2014 at 04:46:05PM +0100, Lukasz Majewski wrote:
> Hi Tom,
>
> > The calloc() call was allocating space for the sizeof the struct
> > pointer rather than for the struct contents.
> > Besides, since this buffer is passed to mmc for writing and some
> > platforms may use cache, the legacy_mbr struct should be
> > cache-aligned.
>
> Is there any problem with this patch?
Just started re-reviewing this one today in fact, good timing.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140224/1644ca72/attachment.pgp>
next prev parent reply other threads:[~2014-02-24 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 8:48 [U-Boot] [PATCH v2] part_efi: fix protective mbr struct allocation Hector Palacios
2014-02-13 13:06 ` Lukasz Majewski
2014-02-24 15:46 ` Lukasz Majewski
2014-02-24 15:52 ` Tom Rini [this message]
2014-02-25 13:57 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224155244.GO16805@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox