From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mmc: postponed needless timer initialization
Date: Thu, 22 May 2014 12:43:33 +0200 [thread overview]
Message-ID: <20140522124333.5d3a9a85@amdc2363> (raw)
In-Reply-To: <1398795330-24319-1-git-send-email-m.zalega@samsung.com>
Hi Pantelis,
> mmc_init() doesn't call get_timer() anymore if MMC is already
> initialized.
>
> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> Detached from earlier "DFU, MMC, Gadget, Goni, misc." series because
> of lack of relevance to other patches.
>
> v2:
> - deleted change-id line from commit message, sorry!
> ---
> drivers/mmc/mmc.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 16051e5..c93dc24 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1310,15 +1310,18 @@ static int mmc_complete_init(struct mmc *mmc)
> int mmc_init(struct mmc *mmc)
> {
> int err = IN_PROGRESS;
> - unsigned start = get_timer(0);
> + unsigned start;
>
> if (mmc->has_init)
> return 0;
> +
> + start = get_timer(0);
> +
> if (!mmc->init_in_progress)
> err = mmc_start_init(mmc);
> -
> if (!err || err == IN_PROGRESS)
> err = mmc_complete_init(mmc);
> +
> debug("%s: %d, time %lu\n", __func__, err, get_timer(start));
> return err;
> }
Would you find some time to review this patch?
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2014-05-22 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 17:16 [U-Boot] [PATCH] common: fixed linker-list example Mateusz Zalega
2014-04-29 17:16 ` [U-Boot] [PATCH] mmc: postponed needless timer initialization Mateusz Zalega
2014-04-29 17:25 ` Pantelis Antoniou
2014-04-29 18:15 ` [U-Boot] [PATCH v2] " Mateusz Zalega
2014-05-22 10:43 ` Lukasz Majewski [this message]
2014-05-23 8:21 ` Pantelis Antoniou
2014-04-29 18:14 ` [U-Boot] [PATCH v2] common: fixed linker-list example Mateusz Zalega
2014-05-05 8:27 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522124333.5d3a9a85@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox