From: Maxin B. John <maxin.john@enea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtdcore: Fix a build error with CONFIG_CMD_MTDPARTS_SPREAD
Date: Mon, 7 Jul 2014 15:17:10 +0200 [thread overview]
Message-ID: <20140707131710.GA14901@sestofb10.enea.se> (raw)
In-Reply-To: <20140707121709.DCC68383356@gemini.denx.de>
Dear Wolfgang,
On Mon, Jul 07, 2014 at 02:17:09PM +0200, Wolfgang Denk wrote:
> Dear Maxin,
>
> In message <1404729444-10957-1-git-send-email-maxin.john@enea.com> you wrote:
> > This patch fixes the build error for CONFIG_CMD_MTDPARTS_SPREAD
> > introduced by the commit:
> >
> > commit dfe64e2c89731a3f9950d7acd8681b68df2bae03
> > Author: Sergey Lapin <slapin@ossfans.org>
> > Date: Mon Jan 14 03:46:50 2013 +0000
> >
> > mtd: resync with Linux-3.7.1
>
> Can you please check if this patch is still needed with the updated
> MTD code posted by Heiko [1] - and if so, rebase your patch against
> Heiko's code base?
>
> Thanks.
>
> [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/189358
Thank you very much for pointing this out. I have tested Heiko's code
available here:
repo: git://git.denx.de/u-boot-testing.git
branch: update-v3-mtd+ubi-linux-v3.14
The build error that was mentioned in this mail is still valid there:
LD drivers/pcmcia/built-in.o
drivers/mtd/mtdcore.c: In function 'mtd_get_len_incl_bad':
drivers/mtd/mtdcore.c:805:10: error: 'struct mtd_info' has no member
named 'block_isbad'
drivers/mtd/mtdcore.c:821:11: error: 'struct mtd_info' has no member
named 'block_isbad'
CC drivers/rtc/date.o
make[1]: *** [drivers/mtd/mtdcore.o] Error 1
make: *** [drivers/mtd] Error 2
make: *** Waiting for unfinished jobs....
Also re-created patch against this. Should I send it as a separate
patch or would you suggest another branch for this fix ?
>
> Best regards,
> Wolfgang Denk
Best Regards,
Maxin B. John
next prev parent reply other threads:[~2014-07-07 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 10:37 [U-Boot] [PATCH] mtdcore: Fix a build error with CONFIG_CMD_MTDPARTS_SPREAD Maxin B. John
2014-07-07 12:17 ` Wolfgang Denk
2014-07-07 13:17 ` Maxin B. John [this message]
2014-07-07 13:35 ` Heiko Schocher
2014-07-07 13:40 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2014-09-08 17:04 Maxin B. John
2014-09-15 8:00 ` Maxin B. John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707131710.GA14901@sestofb10.enea.se \
--to=maxin.john@enea.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox