public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] buildman: refactor help message (This has been superseded !)
Date: Fri, 22 Aug 2014 19:21:57 +0900	[thread overview]
Message-ID: <20140822192156.A0AF.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1408598899-20475-1-git-send-email-yamada.m@jp.panasonic.com>

Hi Tom,


I notice this patch is already marked as Under Review
and I guess you are testing it locally now.

If it is not too late, could you replace it with v2 please?
http://patchwork.ozlabs.org/patch/382136/


I found "-b <branch>" is not a mandatory option.


Best Regards
Masahiro Yamada





On Thu, 21 Aug 2014 14:28:19 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:

> "buildman [options]" is displayed by default.
> 
> Append the rest of help messages to parser.usage
> instead of replacing it.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  tools/buildman/buildman.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
> index 6ca8dc6..9b0c9a0 100755
> --- a/tools/buildman/buildman.py
> +++ b/tools/buildman/buildman.py
> @@ -118,7 +118,7 @@ parser.add_option('-u', '--show_unknown', action='store_true',
>  parser.add_option('-v', '--verbose', action='store_true',
>         default=False, help='Show build results while the build progresses')
>  
> -parser.usage = """buildman -b <branch> [options]
> +parser.usage += """ -b <branch>
>  
>  Build U-Boot for all commits in a branch. Use -n to do a dry run"""
>  
> -- 
> 1.9.1

  reply	other threads:[~2014-08-22 10:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21  5:28 [U-Boot] [PATCH] buildman: refactor help message Masahiro Yamada
2014-08-22 10:21 ` Masahiro Yamada [this message]
2014-08-22 14:43   ` [U-Boot] [PATCH] buildman: refactor help message (This has been superseded !) Tom Rini
2014-08-23  2:01 ` [U-Boot] [PATCH] buildman: refactor help message Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140822192156.A0AF.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox