[U-Boot] [PATCH] buildman: refactor help message

[U-Boot] [PATCH] buildman: refactor help message

[Masahiro Yamada]

"buildman [options]" is displayed by default.

Append the rest of help messages to parser.usage
instead of replacing it.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 tools/buildman/buildman.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
index 6ca8dc6..9b0c9a0 100755
--- a/tools/buildman/buildman.py
+++ b/tools/buildman/buildman.py
@@ -118,7 +118,7 @@ parser.add_option('-u', '--show_unknown', action='store_true',
 parser.add_option('-v', '--verbose', action='store_true',
        default=False, help='Show build results while the build progresses')
 
-parser.usage = """buildman -b <branch> [options]
+parser.usage += """ -b <branch>
 
 Build U-Boot for all commits in a branch. Use -n to do a dry run"""
 
-- 
1.9.1

[U-Boot] [PATCH] buildman: refactor help message (This has been superseded !)

[Masahiro Yamada]

Hi Tom,


I notice this patch is already marked as Under Review
and I guess you are testing it locally now.

If it is not too late, could you replace it with v2 please?
http://patchwork.ozlabs.org/patch/382136/


I found "-b <branch>" is not a mandatory option.


Best Regards
Masahiro Yamada





On Thu, 21 Aug 2014 14:28:19 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:

> "buildman [options]" is displayed by default.
> 
> Append the rest of help messages to parser.usage
> instead of replacing it.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  tools/buildman/buildman.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
> index 6ca8dc6..9b0c9a0 100755
> --- a/tools/buildman/buildman.py
> +++ b/tools/buildman/buildman.py
> @@ -118,7 +118,7 @@ parser.add_option('-u', '--show_unknown', action='store_true',
>  parser.add_option('-v', '--verbose', action='store_true',
>         default=False, help='Show build results while the build progresses')
>  
> -parser.usage = """buildman -b <branch> [options]
> +parser.usage += """ -b <branch>
>  
>  Build U-Boot for all commits in a branch. Use -n to do a dry run"""
>  
> -- 
> 1.9.1

[U-Boot] [PATCH] buildman: refactor help message (This has been superseded !)

[Tom Rini]

On Fri, Aug 22, 2014 at 07:21:57PM +0900, Masahiro Yamada wrote:

> Hi Tom,
> 
> 
> I notice this patch is already marked as Under Review
> and I guess you are testing it locally now.
> 
> If it is not too late, could you replace it with v2 please?
> http://patchwork.ozlabs.org/patch/382136/

Will do, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140822/885ab26e/attachment.pgp>

[U-Boot] [PATCH] buildman: refactor help message

[Simon Glass]

Hi Masahiro,

On 20 August 2014 23:28, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> "buildman [options]" is displayed by default.
>
> Append the rest of help messages to parser.usage
> instead of replacing it.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
>  tools/buildman/buildman.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
> index 6ca8dc6..9b0c9a0 100755
> --- a/tools/buildman/buildman.py
> +++ b/tools/buildman/buildman.py
> @@ -118,7 +118,7 @@ parser.add_option('-u', '--show_unknown', action='store_true',
>  parser.add_option('-v', '--verbose', action='store_true',
>         default=False, help='Show build results while the build progresses')
>
> -parser.usage = """buildman -b <branch> [options]
> +parser.usage += """ -b <branch>

Actually, it's my mistake but the -b argument is now optional. So
perhaps it could be:

> +parser.usage += """ [-b <branch>]

Regards,
Simon