* [U-Boot] [PATCH] arm: am335x: add Kconfig range attribute to prevent invalid CONS_INDEX
@ 2014-08-31 16:05 Masahiro Yamada
2014-08-31 16:40 ` Tom Rini
2014-09-04 20:47 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2014-08-31 16:05 UTC (permalink / raw)
To: u-boot
The help message in board/ti/am335x/Kconfig says AM335x has
6 UARTs, so the valid number for CONFIG_CONS_INDEX is from 1 to 6.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Tom Rini <trini@ti.com>
---
BTW, why does CONFIG_CONS_INDEX start from 1, not 0.
CONFIG_CONS_INDEX=1 correponds to UART0 ?
board/ti/am335x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/board/ti/am335x/Kconfig b/board/ti/am335x/Kconfig
index 0e5149c..80701f5 100644
--- a/board/ti/am335x/Kconfig
+++ b/board/ti/am335x/Kconfig
@@ -22,6 +22,7 @@ config SYS_CONFIG_NAME
config CONS_INDEX
int "UART used for console"
+ range 1 6
default 1
help
The AM335x SoC has a total of 6 UARTs (UART0 to UART5 as referenced
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: am335x: add Kconfig range attribute to prevent invalid CONS_INDEX
2014-08-31 16:05 [U-Boot] [PATCH] arm: am335x: add Kconfig range attribute to prevent invalid CONS_INDEX Masahiro Yamada
@ 2014-08-31 16:40 ` Tom Rini
2014-09-04 20:47 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2014-08-31 16:40 UTC (permalink / raw)
To: u-boot
On Mon, Sep 01, 2014 at 01:05:32AM +0900, Masahiro Yamada wrote:
> The help message in board/ti/am335x/Kconfig says AM335x has
> 6 UARTs, so the valid number for CONFIG_CONS_INDEX is from 1 to 6.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Tom Rini <trini@ti.com>
> ---
>
> BTW, why does CONFIG_CONS_INDEX start from 1, not 0.
>
> CONFIG_CONS_INDEX=1 correponds to UART0 ?
CONFIG_CONS_INDEX is 1-based, AM33xx TRM has UARTs 0-based, so yes, we
map things as you're thinking.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140831/812539ef/attachment.pgp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] arm: am335x: add Kconfig range attribute to prevent invalid CONS_INDEX
2014-08-31 16:05 [U-Boot] [PATCH] arm: am335x: add Kconfig range attribute to prevent invalid CONS_INDEX Masahiro Yamada
2014-08-31 16:40 ` Tom Rini
@ 2014-09-04 20:47 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2014-09-04 20:47 UTC (permalink / raw)
To: u-boot
On Mon, Sep 01, 2014 at 01:05:32AM +0900, Masahiro Yamada wrote:
> The help message in board/ti/am335x/Kconfig says AM335x has
> 6 UARTs, so the valid number for CONFIG_CONS_INDEX is from 1 to 6.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Tom Rini <trini@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140904/16d510d8/attachment.pgp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-04 20:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-31 16:05 [U-Boot] [PATCH] arm: am335x: add Kconfig range attribute to prevent invalid CONS_INDEX Masahiro Yamada
2014-08-31 16:40 ` Tom Rini
2014-09-04 20:47 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox