From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] usb: eth: smsc95xx: Add EEPROM access support
Date: Tue, 7 Oct 2014 19:51:57 +0200 [thread overview]
Message-ID: <20141007175157.GB22589@amd> (raw)
In-Reply-To: <20141007153540.322d3264@avionic-0020>
Hi!
> > > +static u8 eeprom_defaults[] = {
> > > + /* 0x00 */
> > > + 0xA5, /* Signature */
> > > + 0xFF, 0xFF, /* MAC bytes 0-1 */
> > > + 0xFF, 0xFF, /* MAC bytes 2-3 */
> > > + 0xFF, 0xFF, /* MAC bytes 4-5 */
> >
> > Normally, we use all zeros for unset...?
>
> That's what the controller use when the EEPROM hasn't been programmed,
> but I'll change it to all 0.
Aha, if this is in-controller-default, don't change it. But comment
explaining where this comes from would be nice.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2014-10-07 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 9:19 [U-Boot] [PATCH 1/2] net: Add a command to access the EEPROM from ethernet devices Alban Bedel
2014-10-07 9:19 ` [U-Boot] [PATCH 2/2] usb: eth: smsc95xx: Add EEPROM access support Alban Bedel
2014-10-07 12:22 ` Pavel Machek
2014-10-07 13:35 ` Alban Bedel
2014-10-07 13:40 ` Marek Vasut
2014-10-07 17:51 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007175157.GB22589@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox