From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/1] fs: fat/ext4/sandbox: Deal with files > 2GB in ls and size commands
Date: Wed, 8 Oct 2014 22:35:54 +0200 [thread overview]
Message-ID: <20141008203554.GA9751@amd> (raw)
In-Reply-To: <1412799828-3412-1-git-send-email-suriyan.r@gmail.com>
On Wed 2014-10-08 13:23:48, Suriyan Ramasami wrote:
> The commands fatls/ext4ls give -ve values when dealing with files > 2GB.
> The commands fatsize/ext4size do not update the variable filesize for
> these files.
>
> To deal with this, the functions *_size have been modified to take a second
> parameter of type "* off_t" which is then populated. The return value of the
> *_size function is then only used to determine error conditions.
Would not it be better to simply change return type of affected
functions to off_t?
(If off_t is unsigned, invent signed off_t. It is still nicer than
extra parameter.)
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-10-08 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:23 [U-Boot] [PATCH v1 1/1] fs: fat/ext4/sandbox: Deal with files > 2GB in ls and size commands Suriyan Ramasami
2014-10-08 20:35 ` Pavel Machek [this message]
2014-10-08 21:08 ` Suriyan Ramasami
2014-10-08 21:45 ` Pavel Machek
2014-10-08 20:44 ` Simon Glass
2014-10-08 21:54 ` Suriyan Ramasami
2014-10-09 15:42 ` Simon Glass
2014-10-17 19:17 ` Suriyan Ramasami
2014-10-17 19:44 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008203554.GA9751@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox