public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd
Date: Sun, 21 Dec 2014 17:01:07 -0500	[thread overview]
Message-ID: <20141221220107.GC10826@bill-the-cat> (raw)
In-Reply-To: <1419197651.2453.4.camel@nswph.gme.net.au>

On Mon, Dec 22, 2014 at 08:34:11AM +1100, Peter Howard wrote:
> On Fri, 2014-12-19 at 16:53 -0500, Tom Rini wrote:
> > In f0c3a6c we stopped setting gd in board_init_f, but later had to
> > revert to due problems on certain platforms.  As davinci does not look
> > to have these problems, we can drop the setting here and rely upon
> > crt0.S to do it.
> > 
> > Cc: Peter Howard <pjh@northern-ridge.com.au>
> > Signed-off-by: Tom Rini <trini@ti.com>
> > 
> > ---
> > Peter, I don't have my davinci board hooked up but since you were doing
> > some changes recently is there a chance you can test this easily?
> > Thanks!
> 
> Applied this patch (with and without 1/1 as well - given part 1 is ARMv7
> it shouldn't have any bearing on davinci but wanted to be sure).
> 
> U-boot doesn't boot on the da850evm with this change.  I tried both with
> my changes to the generic board, and on a fresh clone of u-boot.git. And
> on u-boot-ti.git.  I haven't looked further, but I'm guessing there is
> early access to gd of the sort you patched out for v7.

Thanks for testing, I feared it wasn't quite as easy as it looked, I'll
have a think about it and see if I can recall what else might be
tickling gd that early over there.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141221/bc48543b/attachment.pgp>

  reply	other threads:[~2014-12-21 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 21:53 [U-Boot] [PATCH RFT 1/2] TI ARMv7: Don't use GD before crt0.S has set it Tom Rini
2014-12-19 21:53 ` [U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd Tom Rini
2014-12-19 23:54   ` Peter Howard
2014-12-21 21:34   ` Peter Howard
2014-12-21 22:01     ` Tom Rini [this message]
2014-12-21 18:52 ` [U-Boot] [PATCH RFT 1/2] TI ARMv7: Don't use GD before crt0.S has set it Simon Glass
2015-01-20 21:40 ` [U-Boot] [U-Boot, RFT, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141221220107.GC10826@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox