public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Howard <pjh@northern-ridge.com.au>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd
Date: Sat, 20 Dec 2014 10:54:09 +1100	[thread overview]
Message-ID: <1419033249.3987.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1419026005-5549-2-git-send-email-trini@ti.com>

On Fri, 2014-12-19 at 16:53 -0500, Tom Rini wrote:
> In f0c3a6c we stopped setting gd in board_init_f, but later had to
> revert to due problems on certain platforms.  As davinci does not look
> to have these problems, we can drop the setting here and rely upon
> crt0.S to do it.
> 
> Cc: Peter Howard <pjh@northern-ridge.com.au>
> Signed-off-by: Tom Rini <trini@ti.com>
> 
> ---
> Peter, I don't have my davinci board hooked up but since you were doing
> some changes recently is there a chance you can test this easily?

I can test on Monday - I only have access to my LCDK on the weekend, and
I have to get round to try the convoluted setup process for flashing
u-boot on it :-)

> Thanks!
> ---
>  arch/arm/cpu/arm926ejs/davinci/spl.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/davinci/spl.c b/arch/arm/cpu/arm926ejs/davinci/spl.c
> index 59b304e..7b14420 100644
> --- a/arch/arm/cpu/arm926ejs/davinci/spl.c
> +++ b/arch/arm/cpu/arm926ejs/davinci/spl.c
> @@ -51,7 +51,6 @@ void board_init_f(ulong dummy)
>  	memset(__bss_start, 0, __bss_end - __bss_start);
>  
>  	/* Finally, setup gd and move to the next step. */
> -	gd = &gdata;
>  	board_init_r(NULL, 0);
>  }
>  

  reply	other threads:[~2014-12-19 23:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 21:53 [U-Boot] [PATCH RFT 1/2] TI ARMv7: Don't use GD before crt0.S has set it Tom Rini
2014-12-19 21:53 ` [U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd Tom Rini
2014-12-19 23:54   ` Peter Howard [this message]
2014-12-21 21:34   ` Peter Howard
2014-12-21 22:01     ` Tom Rini
2014-12-21 18:52 ` [U-Boot] [PATCH RFT 1/2] TI ARMv7: Don't use GD before crt0.S has set it Simon Glass
2015-01-20 21:40 ` [U-Boot] [U-Boot, RFT, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419033249.3987.1.camel@localhost.localdomain \
    --to=pjh@northern-ridge.com.au \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox