From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fw_env.h: include autoconf.h
Date: Thu, 16 Apr 2015 13:20:10 -0400 [thread overview]
Message-ID: <20150416172010.GB16702@bill-the-cat> (raw)
In-Reply-To: <7c8f1b7e3881f278cd42e3ab43c0d6e269df5d21.1429027426.git.marcel.ziswiler@toradex.com>
On Tue, Apr 14, 2015 at 09:50:47PM +0200, Marcel Ziswiler wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Without this, when CONFIG_ENV_VARS_UBOOT_CONFIG is active we get
> a compile time error when doing 'make env'.
> In file included from tools/env/fw_env.c:117:0:
> include/env_default.h:110:11: error: expected ?}? before ?CONFIG_SYS_ARCH?
>
> When building U-Boot this is included indirectly by the compiler switch
> -include
> /home/trdx/git.toradex.com/u-boot-2014.10-toradex/include/linux/kconfig.h
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> This is an issue on all tegra boards due CONFIG_ENV_VARS_UBOOT_CONFIG
> being defined in the tegra-common.h header file.
>
> I already did reported this once last November but did not get any
> useful insights back then:
Ug. I'm cc'ing a few distro people since this makes it further clear
that by whatever name a distro packages fw_setenv/fw_getenv these are
really machine (to the extent U-Boot is built) specific applications due
to the need to include a copy of the default environment so that we
can support making sure that variables that aren't supposed to be
overwritten are not overwritten (see the fw_getdefenv call in
tools/env/fw_env.c::fw_env_write).
I'll let Masahiro comment on if this is the best way to fix the compile
problem.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150416/71ff2878/attachment.sig>
next prev parent reply other threads:[~2015-04-16 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 19:50 [U-Boot] [PATCH] fw_env.h: include autoconf.h Marcel Ziswiler
2015-04-16 17:20 ` Tom Rini [this message]
2015-05-05 12:19 ` Marcel Ziswiler
2015-05-07 3:03 ` Masahiro Yamada
2015-05-05 23:59 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416172010.GB16702@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox