* [U-Boot] [PATCH 1/2] integrator: stop zeroing the gd flags
@ 2015-04-21 13:35 Linus Walleij
2015-04-21 22:35 ` Simon Glass
2015-04-23 13:15 ` [U-Boot] [U-Boot,1/2] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2015-04-21 13:35 UTC (permalink / raw)
To: u-boot
This assignment conflicts with code that add flags with
gd->flags |= FOO prior to the execution of this function.
Seems like a historical artifact and creates bugs with
early alloc().
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
board/armltd/integrator/integrator.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c
index f0fe0fd3aabe..e94ac850c751 100644
--- a/board/armltd/integrator/integrator.c
+++ b/board/armltd/integrator/integrator.c
@@ -54,8 +54,6 @@ int board_init (void)
/* adress of boot parameters */
gd->bd->bi_boot_params = 0x00000100;
- gd->flags = 0;
-
#ifdef CONFIG_CM_REMAP
extern void cm_remap(void);
cm_remap(); /* remaps writeable memory to 0x00000000 */
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/2] integrator: stop zeroing the gd flags
2015-04-21 13:35 [U-Boot] [PATCH 1/2] integrator: stop zeroing the gd flags Linus Walleij
@ 2015-04-21 22:35 ` Simon Glass
2015-04-23 13:15 ` [U-Boot] [U-Boot,1/2] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2015-04-21 22:35 UTC (permalink / raw)
To: u-boot
On 21 April 2015 at 07:35, Linus Walleij <linus.walleij@linaro.org> wrote:
> This assignment conflicts with code that add flags with
> gd->flags |= FOO prior to the execution of this function.
> Seems like a historical artifact and creates bugs with
> early alloc().
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> board/armltd/integrator/integrator.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot,1/2] integrator: stop zeroing the gd flags
2015-04-21 13:35 [U-Boot] [PATCH 1/2] integrator: stop zeroing the gd flags Linus Walleij
2015-04-21 22:35 ` Simon Glass
@ 2015-04-23 13:15 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2015-04-23 13:15 UTC (permalink / raw)
To: u-boot
On Tue, Apr 21, 2015 at 03:35:59PM +0200, Linus Walleij wrote:
> This assignment conflicts with code that add flags with
> gd->flags |= FOO prior to the execution of this function.
> Seems like a historical artifact and creates bugs with
> early alloc().
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150423/c92049d3/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-23 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-21 13:35 [U-Boot] [PATCH 1/2] integrator: stop zeroing the gd flags Linus Walleij
2015-04-21 22:35 ` Simon Glass
2015-04-23 13:15 ` [U-Boot] [U-Boot,1/2] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox