From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] spl, common, serial: build SPL without serial support
Date: Mon, 15 Jun 2015 11:32:13 -0400 [thread overview]
Message-ID: <20150615153213.GX1728@bill-the-cat> (raw)
In-Reply-To: <1434370862-8203-2-git-send-email-hs@denx.de>
On Mon, Jun 15, 2015 at 02:20:59PM +0200, Heiko Schocher wrote:
> This patch enables building SPL without
> CONFIG_SPL_SERIAL_SUPPORT support.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
I like that we're starting down this path. But can you explain why we
need each of these changes:
> arch/arm/lib/interrupts.c | 4 ++--
> arch/arm/mach-at91/arm926ejs/cpu.c | 2 +-
> common/cli_readline.c | 2 +-
> common/cli_simple.c | 2 +-
> lib/display_options.c | 4 ++--
Having gone down the path of disabling output in SPL before due to size
constraints I didn't need to modify those files (but it was on an older
version)
> common/image.c | 8 ++++++--
In this case I just said we only need those functions (and their
strings!) when we have SPL_SERIAL available. It may be worth
re-checking what parts of this file we really need available in SPL
even.
> common/spl/spl.c | 9 +++++++++
We should be able to be fine without a preloader_console_init() func I
think.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150615/f355e9fd/attachment.sig>
next prev parent reply other threads:[~2015-06-15 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:20 [U-Boot] [PATCH 0/4] add support for the at91 based smartweb board Heiko Schocher
2015-06-15 12:20 ` [U-Boot] [PATCH 1/4] spl, common, serial: build SPL without serial support Heiko Schocher
2015-06-15 15:32 ` Tom Rini [this message]
2015-06-16 5:21 ` Heiko Schocher
2015-06-15 12:21 ` [U-Boot] [PATCH 2/4] nand, atmel: remove udelay in spl_nand_erase_one() Heiko Schocher
2015-06-15 23:41 ` Scott Wood
2015-06-15 12:21 ` [U-Boot] [PATCH 3/4] lib/display_options: fix compiler warnings Heiko Schocher
2015-06-15 14:43 ` Tom Rini
2015-06-16 4:44 ` Heiko Schocher
2015-06-15 12:21 ` [U-Boot] [PATCH 4/4] arm, at91: support for sam9260 based smwartweb board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615153213.GX1728@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox