[U-Boot] [PATCH] usb: kbd: Prevent out of bound access

[U-Boot] [PATCH] usb: kbd: Prevent out of bound access

[Marek Vasut]

Scan code 0x39 is CapsLock, which is not a printable character and thus
is not covered by either usb_kbd_numkey_shifted[] or usb_kbd_numkey[].
Fix the scan code check to avoid looking it up in either of the arrays.

Signed-off-by: Marek Vasut <marex@denx.de>
---
 common/usb_kbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index cbb1995..d84865f 100644
--- a/common/usb_kbd.c
+++ b/common/usb_kbd.c
@@ -199,7 +199,7 @@ static int usb_kbd_translate(struct usb_kbd_pdata *data, unsigned char scancode,
 		}
 	}
 
-	if ((scancode > 0x1d) && (scancode < 0x3a)) {
+	if ((scancode > 0x1d) && (scancode < 0x39)) {
 		/* Shift pressed */
 		if (modifier & (LEFT_SHIFT | RIGHT_SHIFT))
 			keycode = usb_kbd_numkey_shifted[scancode - 0x1e];
-- 
2.1.4

[U-Boot] [PATCH] usb: kbd: Prevent out of bound access

[Tom Rini]

On Mon, Jan 25, 2016 at 10:08:50PM +0100, Marek Vasut wrote:

> Scan code 0x39 is CapsLock, which is not a printable character and thus
> is not covered by either usb_kbd_numkey_shifted[] or usb_kbd_numkey[].
> Fix the scan code check to avoid looking it up in either of the arrays.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160125/82399c9d/attachment.sig>