[U-Boot] [PATCH] serial: 16550: Make serial_io/out_shift available to debug mode

[U-Boot] [PATCH] serial: 16550: Make serial_io/out_shift available to debug mode

[Marek Vasut]

The ns16550 driver needs serial_in_shift() and serial_out_shift()
when compiled in debug UART mode, so shift the DM_SERIAL check a
little to make these functions available.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
 drivers/serial/ns16550.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 28da9dd..a1a26a2 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -54,12 +54,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define CONFIG_SYS_NS16550_IER  0x00
 #endif /* CONFIG_SYS_NS16550_IER */
 
-#ifdef CONFIG_DM_SERIAL
-
-#ifndef CONFIG_SYS_NS16550_CLK
-#define CONFIG_SYS_NS16550_CLK  0
-#endif
-
 static inline void serial_out_shift(void *addr, int shift, int value)
 {
 #ifdef CONFIG_SYS_NS16550_PORT_MAPPED
@@ -94,6 +88,12 @@ static inline int serial_in_shift(void *addr, int shift)
 #endif
 }
 
+#ifdef CONFIG_DM_SERIAL
+
+#ifndef CONFIG_SYS_NS16550_CLK
+#define CONFIG_SYS_NS16550_CLK  0
+#endif
+
 static void ns16550_writeb(NS16550_t port, int offset, int value)
 {
 	struct ns16550_platdata *plat = port->plat;
-- 
2.7.0

[U-Boot] [PATCH] serial: 16550: Make serial_io/out_shift available to debug mode

[Tom Rini]

On Wed, May 25, 2016 at 02:13:03AM +0200, Marek Vasut wrote:

> The ns16550 driver needs serial_in_shift() and serial_out_shift()
> when compiled in debug UART mode, so shift the DM_SERIAL check a
> little to make these functions available.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160530/08ebf88c/attachment.sig>

[U-Boot] [PATCH] serial: 16550: Make serial_io/out_shift available to debug mode

[Simon Glass]

On 25 May 2016 at 12:13, Marek Vasut <marex@denx.de> wrote:
> The ns16550 driver needs serial_in_shift() and serial_out_shift()
> when compiled in debug UART mode, so shift the DM_SERIAL check a
> little to make these functions available.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/serial/ns16550.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] serial: 16550: Make serial_io/out_shift available to debug mode

[Tom Rini]

On Wed, May 25, 2016 at 02:13:03AM +0200, Marek Vasut wrote:

> The ns16550 driver needs serial_in_shift() and serial_out_shift()
> when compiled in debug UART mode, so shift the DM_SERIAL check a
> little to make these functions available.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160603/85aadf80/attachment.sig>