From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: dwc3: fixes crash in dwc3 driver due to types size mismatch
Date: Tue, 26 Jul 2016 09:04:16 -0400 [thread overview]
Message-ID: <20160726130416.GT14698@bill-the-cat> (raw)
In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF6762A8570@DBDE04.ent.ti.com>
On Tue, Jul 26, 2016 at 12:59:14PM +0000, B, Ravi wrote:
> Tom
>
> >> based on phys_addr_t, so it triggered
> >> the problem for DWC3, which had already potentially existed.
> >>
> >>
> >> CONFIGs in Kconfig are guaranteed to be defined for all files, but
> >> CONFIGs in board headers are not.
> >>
> >> So we need to make sure to add
> >> #include <common.h> (or #include <config.h>) in each source file.
> >>
> >>
> >> So, your patch is doing a right thing.
> >>
> >> I will issue my Reviewed-by when you update the git-log.
> >>
> >>
> >> (Moving CONFIG_PHYS_64BIT is a right thing as well)
>
> >Can we move PHYS_64BIT to Kconfig instead here please? This is the kind of thing we should be able to select based on SoC / board. Thanks!
>
> Yes, moving to PHYS_64BIT to Kconfig would be ideal fix. Thanks for pointing out.
>
> I have posted patch.
> Commit: bac9e0: Kconfig: dra7x: Kconfig based PHYS_64BIT select based on Soc type
You missed that Masahiro posted one as well that converted all targets
:( Can you please grab his and confirm that it fixes the problem as
well? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160726/5c1f5c23/attachment.sig>
next prev parent reply other threads:[~2016-07-26 13:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 10:41 [U-Boot] [PATCH] usb: dwc3: fixes crash in dwc3 driver due to types size mismatch Ravi Babu
2016-07-21 11:42 ` Marek Vasut
2016-07-21 12:29 ` B, Ravi
2016-07-21 12:35 ` Marek Vasut
2016-07-21 12:44 ` B, Ravi
2016-07-21 12:54 ` Marek Vasut
2016-07-21 13:03 ` B, Ravi
2016-07-21 13:05 ` Marek Vasut
2016-07-22 5:10 ` Masahiro Yamada
2016-07-22 8:06 ` B, Ravi
2016-07-22 10:19 ` Marek Vasut
2016-07-22 11:55 ` Tom Rini
2016-07-26 12:59 ` B, Ravi
2016-07-26 13:04 ` Tom Rini [this message]
2016-07-26 13:16 ` B, Ravi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726130416.GT14698@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox