From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 08/11] buildman: Avoid overwriting existing toolchain entries
Date: Wed, 27 Jul 2016 23:28:45 -0400 [thread overview]
Message-ID: <20160728032845.GD5926@bill-the-cat> (raw)
In-Reply-To: <1469673188-15834-9-git-send-email-sjg@chromium.org>
On Wed, Jul 27, 2016 at 08:33:05PM -0600, Simon Glass wrote:
> The current code for setting up the toolchain config always writes the new
> paths to an item called 'toolchain'. This means that it will overwrite any
> existing toolchain item with the same name. In practice, this means that:
>
> buildman --fetch-arch all
>
> will fetch all toolchains, but only the path of the final one will be added
> to the config. This normally works out OK, since most toolchains are the
> same version (e.g. gcc 4.9) and will be found on the same path. But it is
> not correct and toolchains for archs which don't use the same version will
> not function as expected.
>
> Adjust the code to use a complete glob of the toolchain path.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160727/8060fab9/attachment-0001.sig>
next prev parent reply other threads:[~2016-07-28 3:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 2:32 [U-Boot] [PATCH v2 00/11] buildman: Make the tool friendlier for first-time users Simon Glass
2016-07-28 2:32 ` [U-Boot] [PATCH v2 01/11] buildman: Tidy up the README a little Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:32 ` [U-Boot] [PATCH v2 02/11] buildman: Automatically create a config file if needed Simon Glass
2016-07-28 3:28 ` Tom Rini
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 03/11] buildman: Fix the 'help' test to use the correct path Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 04/11] buildman: Allow the toolchain error to be suppressed Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 05/11] buildman: Improve the toolchain progress/error output Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 06/11] buildman: Fix a typo in TestSettingsHasPath() Simon Glass
2016-07-28 3:28 ` Tom Rini
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 07/11] buildman: Drop the toolchain error when downloading toolchains Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 08/11] buildman: Avoid overwriting existing toolchain entries Simon Glass
2016-07-28 3:28 ` Tom Rini [this message]
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 09/11] buildman: Add a quick-start note Simon Glass
2016-07-28 3:28 ` Tom Rini
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 10/11] Drop the MAKEALL tool Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 2:33 ` [U-Boot] [PATCH v2 11/11] Drop references to MAKEALL in the documentation Simon Glass
2016-08-01 18:22 ` Simon Glass
2016-07-28 3:28 ` [U-Boot] [PATCH v2 00/11] buildman: Make the tool friendlier for first-time users Tom Rini
2016-07-28 3:32 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728032845.GD5926@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox