U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] recommended place to add some custom settings to u-boot environment?
Date: Wed, 14 Sep 2016 16:31:47 +0200	[thread overview]
Message-ID: <20160914143147.0DC69100BA3@atlas.denx.de> (raw)
In-Reply-To: <alpine.LFD.2.20.1609140935240.5661@ca624034.mitel.com>

Dear Robert,

In message <alpine.LFD.2.20.1609140935240.5661@ca624034.mitel.com> you wrote:
> 
> > It will not realy work.  "space-separated" is not good enough as a
> > space character is a legal part of the value of an environment
> > variable.  You would need to tweak the import code.
> 
>   but himport_r() explicitly takes a separator character, and i can
> guarantee the strings being "imported" have no embedded space
> characters in their values. so as long as that's the case, shouldn't
> himport_r() properly handle that given a separator of space?

Well, yes, but it sounds a bit fragile to me.  Experience tells me
that very soon someone _will_ use a space in a variable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The scientists of today think deeply instead of clearly. One must  be
sane  to think clearly, but one can think deeply and be quite insane.
                                                       - Nikola Tesla

  reply	other threads:[~2016-09-14 14:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14  8:57 [U-Boot] recommended place to add some custom settings to u-boot environment? Robert P. J. Day
2016-09-14  9:17 ` Wolfgang Denk
2016-09-14  9:27   ` Robert P. J. Day
2016-09-14 12:58     ` Wolfgang Denk
2016-09-14 13:04       ` Robert P. J. Day
2016-09-14 13:33         ` Wolfgang Denk
2016-09-14 13:37           ` Robert P. J. Day
2016-09-14 14:31             ` Wolfgang Denk [this message]
2016-09-14 15:07               ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914143147.0DC69100BA3@atlas.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox