From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/9] tegra: select ARM_GIC for Tegra TK1s
Date: Thu, 6 Oct 2016 18:30:49 +0200 [thread overview]
Message-ID: <20161006163049.GA938@kwain> (raw)
In-Reply-To: <87cdf582-3714-9fb2-f4b4-bcc6e20000c3@wwwdotorg.org>
Hi Stephen,
On Thu, Oct 06, 2016 at 10:15:06AM -0600, Stephen Warren wrote:
> On 10/06/2016 08:33 AM, Antoine Tenart wrote:
> >Select the newly introduced ARM_GIC option to the relevant configuration
> >which also have a psci implementation.
>
> >diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig
>
> > config TARGET_JETSON_TK1
> > bool "NVIDIA Tegra124 Jetson TK1 board"
> >+ select ARM_GIC
> > select CPU_V7_HAS_NONSEC
> > select CPU_V7_HAS_VIRT
> > select ARCH_SUPPORT_PSCI
> >
> > config TARGET_CEI_TK1_SOM
> > bool "Colorado Engineering Inc Tegra124 TK1-som board"
> >+ select ARM_GIC
> > select CPU_V7_HAS_NONSEC if !SPL_BUILD
> > select CPU_V7_HAS_VIRT if !SPL_BUILD
> > help
>
> This isn't correct; all Tegra variants have an ARM GIC; it's not
> board-specific. Shouldn't CONFIG_TEGRA or CONFIG_TEGRA_COMMON select
> ARM_GIC?
I focused on adding ARM_GIC for targets using PSCI, but I was hopping
for comments like this one :)
I'll move the ARM_GIC selection to CONFIG_TEGRA or CONFIG_TEGRA_COMMON
then.
Thanks!
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161006/b5aa5a44/attachment.sig>
next prev parent reply other threads:[~2016-10-06 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 14:33 [U-Boot] [PATCH v2 0/9] sunxi: sun5/7i: add the psci suspend function Antoine Tenart
2016-10-06 14:33 ` [U-Boot] [PATCH v2 1/9] ARM: add the ARM_GIC configuration option Antoine Tenart
2016-10-06 14:33 ` [U-Boot] [PATCH v2 2/9] sunxi: select ARM_GIC for sun[6789]i Antoine Tenart
2016-10-06 14:33 ` [U-Boot] [PATCH v2 3/9] ARM: select ARM_GIC for SoCs having a psci implementation Antoine Tenart
2016-10-06 14:33 ` [U-Boot] [PATCH v2 4/9] exynos: select ARM_GIC for TARGET_ARNDALE Antoine Tenart
2016-10-06 14:33 ` [U-Boot] [PATCH v2 5/9] tegra: select ARM_GIC for Tegra TK1s Antoine Tenart
2016-10-06 16:15 ` Stephen Warren
2016-10-06 16:30 ` Antoine Tenart [this message]
2016-10-06 14:33 ` [U-Boot] [PATCH v2 6/9] ARM: PSCI: protect GIC specific code with ARM_GIC Antoine Tenart
2016-10-06 14:33 ` [U-Boot] [PATCH v2 7/9] sun5/7i: add an implementation of the psci suspend function Antoine Tenart
2016-10-06 14:34 ` [U-Boot] [PATCH v2 8/9] sun5i: add defines used by the PSCI code Antoine Tenart
2016-10-06 14:34 ` [U-Boot] [PATCH v2 9/9] sun5i: boot in non-secure mode by default Antoine Tenart
2016-10-07 8:52 ` [U-Boot] [PATCH v2 0/9] sunxi: sun5/7i: add the psci suspend function Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006163049.GA938@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox