From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 3/4] board: sama5d2_xplained: Set 'ethaddr' got from AT24MAC
Date: Sun, 16 Oct 2016 18:03:11 -0400 [thread overview]
Message-ID: <20161016220311.GQ18591@bill-the-cat> (raw)
In-Reply-To: <20161016214201.GA91270@mba.int.er.biessmann.org>
On Sun, Oct 16, 2016 at 11:42:01PM +0200, Andreas Bie?mann wrote:
> Hi Wenyou,
>
> On Tue, Sep 13, 2016 at 10:49:04AM +0800, Wenyou Yang wrote:
> > If 'ethaddr' is not set, we will get the ethernet address from AT24MAC,
> > and set it to 'ethaddr' variable.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > Signed-off-by: Songjun Wu <songjun.wu@microchip.com>
> > Reviewed-by: Andreas Bie?mann <andreas@biessmann.org>
> > ---
> >
> > Changes in v2: None
> >
> > board/atmel/sama5d2_xplained/sama5d2_xplained.c | 51 +++++++++++++++++++++++++
> > include/configs/sama5d2_xplained.h | 6 +++
> > 2 files changed, 57 insertions(+)
> >
>
> <snip>
>
> > diff --git a/include/configs/sama5d2_xplained.h b/include/configs/sama5d2_xplained.h
> > index 77757a3..cada04f 100644
> > --- a/include/configs/sama5d2_xplained.h
> > +++ b/include/configs/sama5d2_xplained.h
> > @@ -15,6 +15,8 @@
> >
> > #include "at91-sama5_common.h"
> >
> > +#define CONFIG_MISC_INIT_R
> > +
> > /* SDRAM */
> > #define CONFIG_NR_DRAM_BANKS 1
> > #define CONFIG_SYS_SDRAM_BASE ATMEL_BASE_DDRCS
> > @@ -54,6 +56,10 @@
> > #define CONFIG_DOS_PARTITION
> > #endif
> >
> > +/* I2C */
> > +#define CONFIG_AT24MAC_ADDR 0x5c
> > +#define CONFIG_AT24MAC_REG 0x9a
>
> these two configs produce compile warnings due to the lately introduced check
> for new config options outside Kconfig.
>
> Please resend with these two options moved to Kconfig of sama5d2_xplained
> board.
Or just not in CONFIG namespace if there's really no reason for them to
be changed / selected. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161016/e3a5077e/attachment.sig>
next prev parent reply other threads:[~2016-10-16 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 2:49 [U-Boot] [PATCH v2 0/4] board: sama5d2_xplained: Convert to use device tree and drivers with DM Wenyou Yang
2016-09-13 2:49 ` [U-Boot] [PATCH v2 1/4] board: sama5d2_xplained: Move config options to defconfigs Wenyou Yang
2016-10-16 20:11 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-09-13 2:49 ` [U-Boot] [PATCH v2 2/4] board: sama5d2_xplained: Clean up code Wenyou Yang
2016-10-16 20:17 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-09-13 2:49 ` [U-Boot] [PATCH v2 3/4] board: sama5d2_xplained: Set 'ethaddr' got from AT24MAC Wenyou Yang
2016-10-16 20:18 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-10-16 21:42 ` Andreas Bießmann
2016-10-16 22:03 ` Tom Rini [this message]
2016-09-13 2:49 ` [U-Boot] [PATCH v2 4/4] board: sama5d2_xplained: Enable an early debug UART Wenyou Yang
2016-10-16 20:20 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161016220311.GQ18591@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox