From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/2] spl: Add spl_early_init()
Date: Fri, 17 Mar 2017 08:09:57 -0400 [thread overview]
Message-ID: <20170317120957.GT19897@bill-the-cat> (raw)
In-Reply-To: <20170315144329.27103-1-sjg@chromium.org>
On Wed, Mar 15, 2017 at 08:43:28AM -0600, Simon Glass wrote:
> From: Eddie Cai <eddie.cai.linux@gmail.com>
>
> At present malloc_base/_limit/_ptr are not initialised in spl_init() when
> we call spl_init() in board_init_f(). This is due to a recent change aimed
> at avoiding overwriting the malloc area set up on some boards by
> spl_relocate_stack_gd().
>
> However if CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN is not defined, we now
> skip setting up the memory area in spl_init() which is obviously wrong.
>
> To fix this, add a new function spl_early_init() which can be called in
> board_init_f().
>
> Fixes: b3d2861e (spl: Remove overwrite of relocated malloc limit)
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> Rewrote spl_{,early_}init() to avoid duplicate code:
> Rewrite/expand commit message:
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170317/75e13861/attachment.sig>
next prev parent reply other threads:[~2017-03-17 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 14:43 [U-Boot] [PATCH v4 1/2] spl: Add spl_early_init() Simon Glass
2017-03-15 14:43 ` [U-Boot] [PATCH v4 2/2] rockchip: rk3288: use spl_early_init() instead of spl_init() Simon Glass
2017-03-16 7:08 ` Kever Yang
2017-03-16 22:22 ` Simon Glass
2017-03-16 15:04 ` Eddie Cai
2017-03-16 22:22 ` Simon Glass
2017-03-16 15:02 ` [U-Boot] [PATCH v4 1/2] spl: Add spl_early_init() Eddie Cai
2017-03-16 22:22 ` Simon Glass
2017-03-17 12:09 ` Tom Rini [this message]
2017-03-20 5:28 ` Lokesh Vutla
2017-03-20 14:27 ` Tom Rini
2017-04-09 19:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317120957.GT19897@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox