public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/2] rockchip: rk3288: use spl_early_init() instead of spl_init()
Date: Thu, 16 Mar 2017 15:08:47 +0800	[thread overview]
Message-ID: <58CA39FF.8060902@rock-chips.com> (raw)
In-Reply-To: <20170315144329.27103-2-sjg@chromium.org>

Hi Eddie, Simon,

Could you help to correct rk3188, rk3399 spl at the same time?

Thanks,
- Kever
On 03/15/2017 10:43 PM, Simon Glass wrote:
> From: Eddie Cai <eddie.cai.linux@gmail.com>
>
> Use spl_early_init() to make sure that early malloc() is initialised. This
> fixes booting on firefly-rk3288, for example.
>
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v4:
> - Change debug() message to match new function name
>
> Changes in v3:
> - Rewrite both commit messages
>
> Changes in v2:
> - Add v2 to the series since this is a new version
>
>   arch/arm/mach-rockchip/rk3288-board-spl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/rk3288-board-spl.c b/arch/arm/mach-rockchip/rk3288-board-spl.c
> index e51e19bb2d..74f3379194 100644
> --- a/arch/arm/mach-rockchip/rk3288-board-spl.c
> +++ b/arch/arm/mach-rockchip/rk3288-board-spl.c
> @@ -185,9 +185,9 @@ void board_init_f(ulong dummy)
>   	debug_uart_init();
>   #endif
>   
> -	ret = spl_init();
> +	ret = spl_early_init();
>   	if (ret) {
> -		debug("spl_init() failed: %d\n", ret);
> +		debug("spl_early_init() failed: %d\n", ret);
>   		hang();
>   	}
>   

  reply	other threads:[~2017-03-16  7:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 14:43 [U-Boot] [PATCH v4 1/2] spl: Add spl_early_init() Simon Glass
2017-03-15 14:43 ` [U-Boot] [PATCH v4 2/2] rockchip: rk3288: use spl_early_init() instead of spl_init() Simon Glass
2017-03-16  7:08   ` Kever Yang [this message]
2017-03-16 22:22     ` Simon Glass
2017-03-16 15:04   ` Eddie Cai
2017-03-16 22:22     ` Simon Glass
2017-03-16 15:02 ` [U-Boot] [PATCH v4 1/2] spl: Add spl_early_init() Eddie Cai
2017-03-16 22:22   ` Simon Glass
2017-03-17 12:09 ` Tom Rini
2017-03-20  5:28 ` Lokesh Vutla
2017-03-20 14:27   ` Tom Rini
2017-04-09 19:34     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58CA39FF.8060902@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox