From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: omap: Unify get_device_type() function
Date: Mon, 5 Jun 2017 09:46:12 -0400 [thread overview]
Message-ID: <20170605134612.GG10782@bill-the-cat> (raw)
In-Reply-To: <fca4b2d4-af80-e67c-e8b1-6b63a0329f77@ti.com>
On Mon, Jun 05, 2017 at 04:00:35PM +0530, Lokesh Vutla wrote:
>
>
> On Friday 02 June 2017 08:30 PM, Sam Protsenko wrote:
> > Refactor OMAP3/4/5 code so that we have only one get_device_type()
> > function for all platforms.
> >
> > Details:
> > - Add ctrl variable for AM33xx and OMAP3 platforms (like it's done for
> > OMAP4/5), so we can obtain status register in common way
> > - For now ctrl structure for AM33xx/OMAP3 contains only status register
> > address
> > - Run hw_data_init() in order to assign ctrl to proper structure
> > - Remove DEVICE_MASK and DEVICE_GP definitions as they are not used
> > (DEVICE_TYPE_MASK and GP_DEVICE are used instead)
> > - Guard structs in omap_common.h with #ifndefs, because otherwise
> > including omap_common.h in am33xx board files breaks compilation
> >
> > Buildman script was run for all OMAP boards. Result output:
> > arm: (for 38/616 boards)
> > all +352.5
> > bss -1.4
> > data +3.5
> > rodata +300.0
> > spl/u-boot-spl:all +284.7
> > spl/u-boot-spl:data +2.2
> > spl/u-boot-spl:rodata +252.0
> > spl/u-boot-spl:text +30.5
> > text +50.4
> > (no errors to report)
> >
> > Tested on AM57x EVM and BeagleBoard xM.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
>
> Will you be able to test on BeagleBoneBlack as well?
I tested v1 of this on am335x-gp-evm. I don't have BBB in my automatic
lab due to how it's powered, and that I only have 1 of those USB hubs I
can control power on each port on. :(
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170605/8d03e68b/attachment.sig>
next prev parent reply other threads:[~2017-06-05 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:00 [U-Boot] [PATCH v2] arm: omap: Unify get_device_type() function Sam Protsenko
2017-06-05 10:30 ` Lokesh Vutla
2017-06-05 13:46 ` Tom Rini [this message]
2017-06-06 2:21 ` Lokesh Vutla
2017-06-10 13:46 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605134612.GG10782@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox