From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] buildman: Translate binutils output to UTF-8
Date: Wed, 7 Jun 2017 14:19:01 +0200 [thread overview]
Message-ID: <20170607121901.16873-1-daniel.schwierzeck@gmail.com> (raw)
In-Reply-To: <20170531134002.5360-1-daniel.schwierzeck@gmail.com>
binutils are using localized output. On systems with locales and special
characters this leads to exceptions like this:
Exception in thread Thread-7:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/u-boot/tools/buildman/builderthread.py", line 475, in run
self.RunJob(job)
File "/u-boot/tools/buildman/builderthread.py", line 456, in RunJob
self._WriteResult(result, job.keep_outputs)
File "/u-boot/tools/buildman/builderthread.py", line 333, in _WriteResult
print >>fd, dump_result.stdout,
UnicodeEncodeError: 'ascii' codec can't encode characters in position 75-76: ordinal not in range(128)
Always encode the value of CommandResult::stdout to UTF-8 before
writing it to stdout or a log file.
Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
Changes in v2:
- encode all occurences of CommandResult::stdout after spawning binutils to UTF-8
- reworded commit message
tools/buildman/builderthread.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index acaf5007f5..4ca2f2eb90 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -280,13 +280,13 @@ class BuilderThread(threading.Thread):
outfile = os.path.join(build_dir, 'log')
with open(outfile, 'w') as fd:
if result.stdout:
- fd.write(result.stdout.encode('latin-1', 'ignore'))
+ fd.write(result.stdout.encode('UTF-8', 'ignore'))
errfile = self.builder.GetErrFile(result.commit_upto,
result.brd.target)
if result.stderr:
with open(errfile, 'w') as fd:
- fd.write(result.stderr.encode('latin-1', 'ignore'))
+ fd.write(result.stderr.encode('UTF-8', 'ignore'))
elif os.path.exists(errfile):
os.remove(errfile)
@@ -319,7 +319,7 @@ class BuilderThread(threading.Thread):
nm = self.builder.GetFuncSizesFile(result.commit_upto,
result.brd.target, fname)
with open(nm, 'w') as fd:
- print >>fd, nm_result.stdout,
+ print >>fd, nm_result.stdout.encode('UTF-8'),
cmd = ['%sobjdump' % self.toolchain.cross, '-h', fname]
dump_result = command.RunPipe([cmd], capture=True,
@@ -330,7 +330,7 @@ class BuilderThread(threading.Thread):
objdump = self.builder.GetObjdumpFile(result.commit_upto,
result.brd.target, fname)
with open(objdump, 'w') as fd:
- print >>fd, dump_result.stdout,
+ print >>fd, dump_result.stdout.encode('UTF-8'),
for line in dump_result.stdout.splitlines():
fields = line.split()
if len(fields) > 5 and fields[1] == '.rodata':
@@ -352,7 +352,7 @@ class BuilderThread(threading.Thread):
sizes = self.builder.GetSizesFile(result.commit_upto,
result.brd.target)
with open(sizes, 'w') as fd:
- print >>fd, '\n'.join(lines)
+ print >>fd, '\n'.join(lines).encode('UTF-8')
# Write out the configuration files, with a special case for SPL
for dirname in ['', 'spl', 'tpl']:
--
2.13.0
next prev parent reply other threads:[~2017-06-07 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 13:40 [U-Boot] [PATCH] buildman: Translate more strings to latin-1 Daniel Schwierzeck
2017-06-01 13:21 ` Simon Glass
2017-06-02 9:18 ` Daniel Schwierzeck
2017-06-02 13:21 ` Tom Rini
2017-06-07 11:55 ` Simon Glass
2017-06-07 12:07 ` Daniel Schwierzeck
2017-06-07 12:19 ` Daniel Schwierzeck [this message]
2017-06-07 15:52 ` [U-Boot] [PATCH v2] buildman: Translate binutils output to UTF-8 Simon Glass
2017-06-07 16:03 ` Daniel Schwierzeck
2017-06-09 12:27 ` Simon Glass
2017-06-09 12:43 ` Daniel Schwierzeck
2017-06-08 1:07 ` [U-Boot] [PATCH 0/2] Fix unicode handling in buildman Daniel Schwierzeck
2017-06-08 1:07 ` [U-Boot] [PATCH 1/2] buildman: disable localized and unicode output of all build tools Daniel Schwierzeck
2017-06-09 0:01 ` sjg at google.com
2017-06-08 1:07 ` [U-Boot] [PATCH 2/2] buildman: properly translate strings for log and err files to ASCII Daniel Schwierzeck
2017-06-09 0:01 ` sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607121901.16873-1-daniel.schwierzeck@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).