U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] buildman: Translate binutils output to UTF-8
Date: Wed, 7 Jun 2017 18:03:45 +0200	[thread overview]
Message-ID: <d1e97b80-86a2-908c-a727-250cfd125d2f@gmail.com> (raw)
In-Reply-To: <CAPnjgZ1HOagCj9SRNCCW8=oOZm1YtypR1Xa1Nxbfs-5yv-ZBvQ@mail.gmail.com>



Am 07.06.2017 um 17:52 schrieb Simon Glass:
> Hi Daniel,
> 
> On 7 June 2017 at 06:19, Daniel Schwierzeck
> <daniel.schwierzeck@gmail.com> wrote:
>> binutils are using localized output. On systems with locales and special
>> characters this leads to exceptions like this:
>>
>> Exception in thread Thread-7:
>> Traceback (most recent call last):
>>   File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
>>     self.run()
>>   File "/u-boot/tools/buildman/builderthread.py", line 475, in run
>>     self.RunJob(job)
>>   File "/u-boot/tools/buildman/builderthread.py", line 456, in RunJob
>>     self._WriteResult(result, job.keep_outputs)
>>   File "/u-boot/tools/buildman/builderthread.py", line 333, in _WriteResult
>>     print >>fd, dump_result.stdout,
>> UnicodeEncodeError: 'ascii' codec can't encode characters in position 75-76: ordinal not in range(128)
>>
>> Always encode the value of CommandResult::stdout to UTF-8 before
>> writing it to stdout or a log file.
>>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - encode all occurences of CommandResult::stdout after spawning binutils to UTF-8
>> - reworded commit message
>>
>>  tools/buildman/builderthread.py | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
> 
> I'm still seeing a rare failure, e.g.:
> 
> https://travis-ci.org/sglass68/u-boot/jobs/240350621
> 
> Any thoughts on that?
> 

I'll look into it

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170607/178e7e0e/attachment.sig>

  reply	other threads:[~2017-06-07 16:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 13:40 [U-Boot] [PATCH] buildman: Translate more strings to latin-1 Daniel Schwierzeck
2017-06-01 13:21 ` Simon Glass
2017-06-02  9:18   ` Daniel Schwierzeck
2017-06-02 13:21     ` Tom Rini
2017-06-07 11:55       ` Simon Glass
2017-06-07 12:07         ` Daniel Schwierzeck
2017-06-07 12:19 ` [U-Boot] [PATCH v2] buildman: Translate binutils output to UTF-8 Daniel Schwierzeck
2017-06-07 15:52   ` Simon Glass
2017-06-07 16:03     ` Daniel Schwierzeck [this message]
2017-06-09 12:27       ` Simon Glass
2017-06-09 12:43         ` Daniel Schwierzeck
2017-06-08  1:07   ` [U-Boot] [PATCH 0/2] Fix unicode handling in buildman Daniel Schwierzeck
2017-06-08  1:07     ` [U-Boot] [PATCH 1/2] buildman: disable localized and unicode output of all build tools Daniel Schwierzeck
2017-06-09  0:01       ` sjg at google.com
2017-06-08  1:07     ` [U-Boot] [PATCH 2/2] buildman: properly translate strings for log and err files to ASCII Daniel Schwierzeck
2017-06-09  0:01       ` sjg at google.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1e97b80-86a2-908c-a727-250cfd125d2f@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox