From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 00/34] env: Move environment code to use location drivers
Date: Tue, 25 Jul 2017 17:47:28 -0400 [thread overview]
Message-ID: <20170725214728.GQ26163@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2=Q_V4bmyMu=KXHnbG-yZyXJjctxv9XASc5hf4HmGP+Q@mail.gmail.com>
On Tue, Jul 25, 2017 at 03:40:42PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On 25 July 2017 at 11:49, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Sun, Jul 23, 2017 at 09:19:35PM -0600, Simon Glass wrote:
> >
> > > The environment code is ripe for improvement in various ways. It has lots
> > > of duplication and inconsistencies between how things work with different
> > > environment locations. It does not properly use Kconfig. Error checking
> > > and handling is patchy.
> > >
> > > This series makes a start at improving things:
> > >
> > > - moves the rest of the CONFIG_ENV_IS_IN_... options to Kconfig
> >
> > I would like to see just this part first, by itself, so we can be sure
> > it's right. I took a quick stab at trying this, and here's a few
> > things:
> > - The freescale SECURE_BOOT boards aren't right.
> > board/freescale/common/Kconfig must have it select ENV_IS_NOWHERE and
> > the other options must depend on !CHAIN_OF_TRUST.
> > - Patch 3 seem to, due to moving things slightly, cause tiny size
> > changes. On balance, this is fine. But in terms of "did Kconfig
> > migration happen correctly" it is not, since it makes it easier for
> > something to slip past.
> >
> > So, I'm going to grab and update the migration portions of this series
> > and have them as a zero size (aside from boards with CMD_CONFIG on)
> > change, hopefully shortly. And then we can still take in the rest of
> > this series, after comments, this release. Sound good? Thanks!
> >
>
> I was unable to make this series avoid effective CONFIG changes as in
> some cases the environment is in one place in SPL (e.g.
> ENV_IS_NOWHERE) and another in U-Boot proper. I assumed that this was
> just going to have to be resolved by maintainers if it is a problem.
>
> Anyway please do whatever you wish and I can rebase the other patches
> afterwards. We have time for people to chime in and adjust things
> later.
OK, thanks! My first pass at size changes is looking good, I think the
*_SECURE_* things might have been what tripped up on the SPL-vs-not as
the code was messy to lead to ENV_IS_NOWHERE being in both. This is
actually going quicker than I thought it might, and I should push the
Kconfig part in today or tomorrow.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170725/588b9205/attachment.sig>
next prev parent reply other threads:[~2017-07-25 21:47 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 3:19 [U-Boot] [PATCH v2 00/34] env: Move environment code to use location drivers Simon Glass
2017-07-24 3:19 ` [U-Boot] [PATCH v2 01/34] configs: Resync with savedefconfig Simon Glass
2017-07-24 3:19 ` [U-Boot] [PATCH v2 02/34] Makefile: Rename 'env' target to 'environ' Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 03/34] Move environment files from common/ to env/ Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 04/34] Convert CONFIG_ENV_IS_IN_MMC et al to Kconfig Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 05/34] env: Move help from README " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 06/34] Convert CONFIG_ENV_IS_IN_FLASH " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 07/34] Convert CONFIG_ENV_IS_IN_NVRAM " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 08/34] Convert CONFIG_ENV_IS_IN_EEPROM " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 09/34] Convert CONFIG_ENV_IS_IN_DATAFLASH " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 10/34] Convert CONFIG_ENV_IS_IN_SPI_FLASH " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 11/34] Convert CONFIG_ENV_IS_IN_REMOTE " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 12/34] Convert CONFIG_ENV_IS_IN_FAT " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 13/34] Convert CONFIG_ENV_IS_IN_ONENAND " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 14/34] env: common: Make env_get_addr/get_char_memory() static Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 15/34] env: common: Drop env_get_addr() Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 16/34] env: common: Factor out the common env_valid check Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 17/34] env: common: Drop env_get_char_init() Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 18/34] env: common: Drop env_get_char_memory() Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 19/34] env: Add an enum for environment state Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 20/34] env: Rename nand env_location to nand_env_location Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 21/34] env: Create a location driver for each location Simon Glass
2017-07-26 16:02 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 22/34] env: Add a new implementation of environment access Simon Glass
2017-07-26 16:04 ` Tom Rini
2017-07-26 16:32 ` Simon Glass
2017-07-26 17:23 ` Tom Rini
2017-07-26 18:02 ` Simon Glass
2017-07-26 20:13 ` Tom Rini
2017-08-01 9:49 ` Simon Glass
2017-07-24 3:19 ` [U-Boot] [PATCH v2 23/34] env: Switch over to use environment location drivers Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 24/34] env: Drop common init() functions Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 25/34] env: Drop the env_name_spec global Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 26/34] env: Drop unused env_ptr variables Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 27/34] env: Drop env_init_new() Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 28/34] env: Drop env_get_char_spec() Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 29/34] env: Drop env_relocate_spec() in favour of env_load() Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 30/34] env: Drop saveenv() in favour of env_save() Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 31/34] env: Rename setenv() and friends to env_set() Simon Glass
2017-07-26 16:11 ` Tom Rini
2017-07-26 16:28 ` Simon Glass
2017-07-26 17:29 ` Tom Rini
2017-07-26 17:43 ` Tom Rini
2017-07-26 18:34 ` Simon Glass
2017-07-26 20:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 32/34] env: Rename getenv() and friends to env_get() Simon Glass
2017-07-26 16:12 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 33/34] env: Adjust the get_char() method to return an int Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 34/34] env: Adjust the load() method to return an error Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-25 17:49 ` [U-Boot] [PATCH v2 00/34] env: Move environment code to use location drivers Tom Rini
2017-07-25 21:40 ` Simon Glass
2017-07-25 21:47 ` Tom Rini [this message]
2017-07-26 4:51 ` Masahiro Yamada
2017-07-28 3:40 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725214728.GQ26163@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox