From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 21/34] env: Create a location driver for each location
Date: Wed, 26 Jul 2017 12:02:41 -0400 [thread overview]
Message-ID: <20170726160241.GG26163@bill-the-cat> (raw)
In-Reply-To: <20170724032009.43994-22-sjg@chromium.org>
On Sun, Jul 23, 2017 at 09:19:56PM -0600, Simon Glass wrote:
> Set up a location driver for each supported environment locatoin. At
> present this just points to the global functions and is not used. A
> later patch will switch this over to use private functions in each driver.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Add conditions for the am335x_hs_evm board with SPL
[snip]
> diff --git a/env/fat.c b/env/fat.c
> index 5a2131a5a9..8f5fff81ad 100644
> --- a/env/fat.c
> +++ b/env/fat.c
> @@ -19,6 +19,18 @@
> #include <fat.h>
> #include <mmc.h>
>
> +#ifdef CONFIG_SPL_BUILD
> +/* TODO(sjg at chromium.org): Figure out why this is needed */
> +# if !defined(CONFIG_TARGET_AM335X_EVM) || defined(CONFIG_SPL_OS_BOOT)
> +# define LOADENV
> +# endif
> +#else
> +# define LOADENV
> +# if defined(CONFIG_CMD_SAVEENV)
> +# define CMD_SAVEENV
> +# endif
> +#endif
Hmm, so. I think we have an out-of-sync with desires defconfig here,
and I'm going to post a few patches shortly since I found some similar
things as part of the env Kconfig series. am335x_hs_evm turned off
almost all of the SPL stuff it doesn't want / need (such as SPL_OS) but
missed SPL_ENV_SUPPORT.
[snip]
> +/* TODO(sjg at chromium.org): Figure out all these special cases */
> +#if (!defined(CONFIG_MICROBLAZE) && !defined(CONFIG_ARCH_ZYNQ) && \
> + !defined(CONFIG_TARGET_MCCMON6) && !defined(CONFIG_TARGET_X600) && \
> + !defined(CONFIG_TARGET_EDMINIV2)) || \
> + !defined(CONFIG_SPL_BUILD)
> +#define LOADENV
> +#endif
I bet some of these special cases are also places where Kconfig logic
and human intentions got slightly out of sync.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170726/6695dfcc/attachment.sig>
next prev parent reply other threads:[~2017-07-26 16:02 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 3:19 [U-Boot] [PATCH v2 00/34] env: Move environment code to use location drivers Simon Glass
2017-07-24 3:19 ` [U-Boot] [PATCH v2 01/34] configs: Resync with savedefconfig Simon Glass
2017-07-24 3:19 ` [U-Boot] [PATCH v2 02/34] Makefile: Rename 'env' target to 'environ' Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 03/34] Move environment files from common/ to env/ Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 04/34] Convert CONFIG_ENV_IS_IN_MMC et al to Kconfig Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 05/34] env: Move help from README " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 06/34] Convert CONFIG_ENV_IS_IN_FLASH " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 07/34] Convert CONFIG_ENV_IS_IN_NVRAM " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 08/34] Convert CONFIG_ENV_IS_IN_EEPROM " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 09/34] Convert CONFIG_ENV_IS_IN_DATAFLASH " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 10/34] Convert CONFIG_ENV_IS_IN_SPI_FLASH " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 11/34] Convert CONFIG_ENV_IS_IN_REMOTE " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 12/34] Convert CONFIG_ENV_IS_IN_FAT " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 13/34] Convert CONFIG_ENV_IS_IN_ONENAND " Simon Glass
2017-07-26 1:36 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 14/34] env: common: Make env_get_addr/get_char_memory() static Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 15/34] env: common: Drop env_get_addr() Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 16/34] env: common: Factor out the common env_valid check Simon Glass
2017-07-26 16:13 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 17/34] env: common: Drop env_get_char_init() Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 18/34] env: common: Drop env_get_char_memory() Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 19/34] env: Add an enum for environment state Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 20/34] env: Rename nand env_location to nand_env_location Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 21/34] env: Create a location driver for each location Simon Glass
2017-07-26 16:02 ` Tom Rini [this message]
2017-07-24 3:19 ` [U-Boot] [PATCH v2 22/34] env: Add a new implementation of environment access Simon Glass
2017-07-26 16:04 ` Tom Rini
2017-07-26 16:32 ` Simon Glass
2017-07-26 17:23 ` Tom Rini
2017-07-26 18:02 ` Simon Glass
2017-07-26 20:13 ` Tom Rini
2017-08-01 9:49 ` Simon Glass
2017-07-24 3:19 ` [U-Boot] [PATCH v2 23/34] env: Switch over to use environment location drivers Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:19 ` [U-Boot] [PATCH v2 24/34] env: Drop common init() functions Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 25/34] env: Drop the env_name_spec global Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 26/34] env: Drop unused env_ptr variables Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 27/34] env: Drop env_init_new() Simon Glass
2017-07-26 16:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 28/34] env: Drop env_get_char_spec() Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 29/34] env: Drop env_relocate_spec() in favour of env_load() Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 30/34] env: Drop saveenv() in favour of env_save() Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 31/34] env: Rename setenv() and friends to env_set() Simon Glass
2017-07-26 16:11 ` Tom Rini
2017-07-26 16:28 ` Simon Glass
2017-07-26 17:29 ` Tom Rini
2017-07-26 17:43 ` Tom Rini
2017-07-26 18:34 ` Simon Glass
2017-07-26 20:14 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 32/34] env: Rename getenv() and friends to env_get() Simon Glass
2017-07-26 16:12 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 33/34] env: Adjust the get_char() method to return an int Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-24 3:20 ` [U-Boot] [PATCH v2 34/34] env: Adjust the load() method to return an error Simon Glass
2017-07-26 16:15 ` Tom Rini
2017-07-25 17:49 ` [U-Boot] [PATCH v2 00/34] env: Move environment code to use location drivers Tom Rini
2017-07-25 21:40 ` Simon Glass
2017-07-25 21:47 ` Tom Rini
2017-07-26 4:51 ` Masahiro Yamada
2017-07-28 3:40 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726160241.GG26163@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox