U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: mvebu: set correct mem_size for db-88f6820-amc
@ 2017-08-17 10:27 Chris Packham
  2017-08-17 11:46 ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Packham @ 2017-08-17 10:27 UTC (permalink / raw)
  To: u-boot

The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
DRAM. Update the board_topology_map to reflect the correct
configuration.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It
happened to work so I never noticed it was wrong until I started seeing
some unexpected mirroring of addresses.

 board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
index 40fa59986573..ac58f9085266 100644
--- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
+++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
@@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
 	      {0x1, 0, 0, 0} },
 	    SPEED_BIN_DDR_1866L,	/* speed_bin */
 	    BUS_WIDTH_8,		/* memory_width */
-	    MEM_4G,			/* mem_size */
+	    MEM_2G,			/* mem_size */
 	    DDR_FREQ_800,		/* frequency */
 	    0, 0,			/* cas_l cas_wl */
 	    HWS_TEMP_LOW,		/* temperature */
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ARM: mvebu: set correct mem_size for db-88f6820-amc
  2017-08-17 10:27 [U-Boot] [PATCH] ARM: mvebu: set correct mem_size for db-88f6820-amc Chris Packham
@ 2017-08-17 11:46 ` Stefan Roese
  2017-08-21  9:41   ` Stefan Roese
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2017-08-17 11:46 UTC (permalink / raw)
  To: u-boot

On 17.08.2017 12:27, Chris Packham wrote:
> The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
> DRAM. Update the board_topology_map to reflect the correct
> configuration.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It
> happened to work so I never noticed it was wrong until I started seeing
> some unexpected mirroring of addresses.
> 
>   board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
> index 40fa59986573..ac58f9085266 100644
> --- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
> +++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
> @@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
>   	      {0x1, 0, 0, 0} },
>   	    SPEED_BIN_DDR_1866L,	/* speed_bin */
>   	    BUS_WIDTH_8,		/* memory_width */
> -	    MEM_4G,			/* mem_size */
> +	    MEM_2G,			/* mem_size */
>   	    DDR_FREQ_800,		/* frequency */
>   	    0, 0,			/* cas_l cas_wl */
>   	    HWS_TEMP_LOW,		/* temperature */
> 

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ARM: mvebu: set correct mem_size for db-88f6820-amc
  2017-08-17 11:46 ` Stefan Roese
@ 2017-08-21  9:41   ` Stefan Roese
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2017-08-21  9:41 UTC (permalink / raw)
  To: u-boot

On 17.08.2017 13:46, Stefan Roese wrote:
> On 17.08.2017 12:27, Chris Packham wrote:
>> The db-88f6820-amc has four chips with 2Gb density giving a total of 1GB
>> DRAM. Update the board_topology_map to reflect the correct
>> configuration.
>>
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>
>> ---
>> When I setup this board I misinterpreted 2 Gigabits as 2 Gigabytes. It
>> happened to work so I never noticed it was wrong until I started seeing
>> some unexpected mirroring of addresses.
>>
>>   board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c 
>> b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>> index 40fa59986573..ac58f9085266 100644
>> --- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>> +++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c
>> @@ -66,7 +66,7 @@ static struct hws_topology_map board_topology_map = {
>>             {0x1, 0, 0, 0} },
>>           SPEED_BIN_DDR_1866L,    /* speed_bin */
>>           BUS_WIDTH_8,        /* memory_width */
>> -        MEM_4G,            /* mem_size */
>> +        MEM_2G,            /* mem_size */
>>           DDR_FREQ_800,        /* frequency */
>>           0, 0,            /* cas_l cas_wl */
>>           HWS_TEMP_LOW,        /* temperature */
>>
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-21  9:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17 10:27 [U-Boot] [PATCH] ARM: mvebu: set correct mem_size for db-88f6820-amc Chris Packham
2017-08-17 11:46 ` Stefan Roese
2017-08-21  9:41   ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox