public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [ANN] U-Boot v2017.11-rc4 released
@ 2017-11-06 23:28 Tom Rini
  2017-11-07  7:13 ` Jorge Ramirez
  0 siblings, 1 reply; 11+ messages in thread
From: Tom Rini @ 2017-11-06 23:28 UTC (permalink / raw)
  To: u-boot

Hey all,

It's release day and v2017.11-rc4 is out.  It's a week until release
day.  Please let me know if you know of any regressions, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171106/983761ce/attachment.sig>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [ANN] U-Boot v2017.11-rc4 released
  2017-11-06 23:28 [U-Boot] [ANN] U-Boot v2017.11-rc4 released Tom Rini
@ 2017-11-07  7:13 ` Jorge Ramirez
  2017-11-07 22:48   ` Tom Rini
  0 siblings, 1 reply; 11+ messages in thread
From: Jorge Ramirez @ 2017-11-07  7:13 UTC (permalink / raw)
  To: u-boot

On 11/07/2017 12:28 AM, Tom Rini wrote:
> Hey all,
>
> It's release day and v2017.11-rc4 is out.  It's a week until release
> day.  Please let me know if you know of any regressions, thanks!

Hi Tom,

emmc accesses are broken for dragonboard410c
I posted the fix [1] last week. will you merge it?

thanks
jorge

[1]PATCH] mmc: sdhci: don't clear SDHCI_INT_STATUS register during 
CMD_INHIBIT

Fixes emmc initialization regression on the db410c platform.

Clearing this register while SDHCI_PRESENT_STATE reports
SDHCI_CMD_INHIBIT leads to undefined behaviour on the db410c.

When commit 7dde50 was merged (mmc: sdhci: Wait for SDHCI_INT_DATA_END
when transferring), SDHCI transfers transitioned to wait for bit
SDHCI_INT_DATA_END before flagging transfers done.

Without this patch, the db410 platform fails to initialize its eMMC
due to all of its transfers timing out (SDHCI_INT_DATA_END is never
raised after all the blocks have been transferred).

Signed-off-by: Jorge Ramirez-Ortiz<jorge.ramirez-ortiz@linaro.org>
---
  drivers/mmc/sdhci.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
index 11d1f0c..f0c5aad 100644
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -157,7 +157,6 @@ static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,
  	/* Timeout unit - ms */
  	static unsigned int cmd_timeout = SDHCI_CMD_DEFAULT_TIMEOUT;
  
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_STATUS);
  	mask = SDHCI_CMD_INHIBIT | SDHCI_DATA_INHIBIT;
  
  	/* We shouldn't wait for data inihibit for stop commands, even
@@ -181,6 +180,8 @@ static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,
  		udelay(1000);
  	}
  
+	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_STATUS);
+
  	mask = SDHCI_INT_RESPONSE;
  	if (!(cmd->resp_type & MMC_RSP_PRESENT))
  		flags = SDHCI_CMD_RESP_NONE;



>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [U-Boot] [ANN] U-Boot v2017.11-rc4 released
  2017-11-07  7:13 ` Jorge Ramirez
@ 2017-11-07 22:48   ` Tom Rini
  2017-11-10 12:29     ` [U-Boot] sdhci - review? Jorge Ramirez
  2017-11-16 12:31     ` [U-Boot] [ANN] U-Boot v2017.11-rc4 released Jaehoon Chung
  0 siblings, 2 replies; 11+ messages in thread
From: Tom Rini @ 2017-11-07 22:48 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
> On 11/07/2017 12:28 AM, Tom Rini wrote:
> >Hey all,
> >
> >It's release day and v2017.11-rc4 is out.  It's a week until release
> >day.  Please let me know if you know of any regressions, thanks!
> 
> Hi Tom,
> 
> emmc accesses are broken for dragonboard410c
> I posted the fix [1] last week. will you merge it?

[1] is: https://patchwork.ozlabs.org/patch/833376/

Jaehoon, are you OK with this patch?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171107/0e450324/attachment.sig>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2017-11-07 22:48   ` Tom Rini
@ 2017-11-10 12:29     ` Jorge Ramirez
  2017-11-20 12:52       ` Jorge Ramirez
  2017-11-16 12:31     ` [U-Boot] [ANN] U-Boot v2017.11-rc4 released Jaehoon Chung
  1 sibling, 1 reply; 11+ messages in thread
From: Jorge Ramirez @ 2017-11-10 12:29 UTC (permalink / raw)
  To: u-boot

On 11/07/2017 11:48 PM, Tom Rini wrote:
> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>> Hey all,
>>>
>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>> day.  Please let me know if you know of any regressions, thanks!
>> Hi Tom,
>>
>> emmc accesses are broken for dragonboard410c
>> I posted the fix [1] last week. will you merge it?

just changed the email subject

> [1] is: https://patchwork.ozlabs.org/patch/833376/
>
> Jaehoon, are you OK with this patch?  Thanks!
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [ANN] U-Boot v2017.11-rc4 released
  2017-11-07 22:48   ` Tom Rini
  2017-11-10 12:29     ` [U-Boot] sdhci - review? Jorge Ramirez
@ 2017-11-16 12:31     ` Jaehoon Chung
  1 sibling, 0 replies; 11+ messages in thread
From: Jaehoon Chung @ 2017-11-16 12:31 UTC (permalink / raw)
  To: u-boot

Hi Tom,

On 2017년 11월 08일 07:48, Tom Rini wrote:
> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>> Hey all,
>>>
>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>> day.  Please let me know if you know of any regressions, thanks!
>>
>> Hi Tom,
>>
>> emmc accesses are broken for dragonboard410c
>> I posted the fix [1] last week. will you merge it?
> 
> [1] is: https://patchwork.ozlabs.org/patch/833376/
> 
> Jaehoon, are you OK with this patch?  Thanks!

If you didn't apply this, i will pick after checking. 
And will send PR with other patches.

Thanks!

Best Regards,
Jaehoon Chung

> 
> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2017-11-10 12:29     ` [U-Boot] sdhci - review? Jorge Ramirez
@ 2017-11-20 12:52       ` Jorge Ramirez
  2017-11-22  8:25         ` Jaehoon Chung
  2018-01-09  9:48         ` Jorge Ramirez
  0 siblings, 2 replies; 11+ messages in thread
From: Jorge Ramirez @ 2017-11-20 12:52 UTC (permalink / raw)
  To: u-boot

On 11/10/2017 01:29 PM, Jorge Ramirez wrote:
> On 11/07/2017 11:48 PM, Tom Rini wrote:
>> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>>> Hey all,
>>>>
>>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>>> day.  Please let me know if you know of any regressions, thanks!
>>> Hi Tom,
>>>
>>> emmc accesses are broken for dragonboard410c
>>> I posted the fix [1] last week. will you merge it?
>
> just changed the email subject
>
>> [1] is: https://patchwork.ozlabs.org/patch/833376/
>>
>> Jaehoon, are you OK with this patch?  Thanks!
>>
>

a ping on this matter - as the db410c maintainer a quick reminder that 
the emmc support remains broken until this (above [1]) (or an 
alternative fix) is merged.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2017-11-20 12:52       ` Jorge Ramirez
@ 2017-11-22  8:25         ` Jaehoon Chung
  2017-11-22 12:27           ` Tom Rini
  2018-01-09  9:48         ` Jorge Ramirez
  1 sibling, 1 reply; 11+ messages in thread
From: Jaehoon Chung @ 2017-11-22  8:25 UTC (permalink / raw)
  To: u-boot

On 11/20/2017 09:52 PM, Jorge Ramirez wrote:
> On 11/10/2017 01:29 PM, Jorge Ramirez wrote:
>> On 11/07/2017 11:48 PM, Tom Rini wrote:
>>> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>>>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>>>> Hey all,
>>>>>
>>>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>>>> day.  Please let me know if you know of any regressions, thanks!
>>>> Hi Tom,
>>>>
>>>> emmc accesses are broken for dragonboard410c
>>>> I posted the fix [1] last week. will you merge it?
>>
>> just changed the email subject
>>
>>> [1] is: https://patchwork.ozlabs.org/patch/833376/
>>>
>>> Jaehoon, are you OK with this patch?  Thanks!
>>>
>>
> 
> a ping on this matter - as the db410c maintainer a quick reminder that the emmc support remains broken until this (above [1]) (or an alternative fix) is merged.

I sent the email to Tom about 1 weeks ago..if it doesn't apply yet, i will pick it..
Maybe i had replied with the my gmail account, something missed.

Sorry.

> 
> 
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2017-11-22  8:25         ` Jaehoon Chung
@ 2017-11-22 12:27           ` Tom Rini
  2017-11-22 12:48             ` Jaehoon Chung
  0 siblings, 1 reply; 11+ messages in thread
From: Tom Rini @ 2017-11-22 12:27 UTC (permalink / raw)
  To: u-boot

On Wed, Nov 22, 2017 at 05:25:02PM +0900, Jaehoon Chung wrote:
> On 11/20/2017 09:52 PM, Jorge Ramirez wrote:
> > On 11/10/2017 01:29 PM, Jorge Ramirez wrote:
> >> On 11/07/2017 11:48 PM, Tom Rini wrote:
> >>> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
> >>>> On 11/07/2017 12:28 AM, Tom Rini wrote:
> >>>>> Hey all,
> >>>>>
> >>>>> It's release day and v2017.11-rc4 is out.  It's a week until release
> >>>>> day.  Please let me know if you know of any regressions, thanks!
> >>>> Hi Tom,
> >>>>
> >>>> emmc accesses are broken for dragonboard410c
> >>>> I posted the fix [1] last week. will you merge it?
> >>
> >> just changed the email subject
> >>
> >>> [1] is: https://patchwork.ozlabs.org/patch/833376/
> >>>
> >>> Jaehoon, are you OK with this patch?  Thanks!
> >>>
> >>
> > 
> > a ping on this matter - as the db410c maintainer a quick reminder that the emmc support remains broken until this (above [1]) (or an alternative fix) is merged.
> 
> I sent the email to Tom about 1 weeks ago..if it doesn't apply yet, i will pick it..
> Maybe i had replied with the my gmail account, something missed.

Yeah, I missed that, sorry.  Please put together a pull request of all
the various outstanding MMC changes ASAP, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171122/16523ec4/attachment.sig>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2017-11-22 12:27           ` Tom Rini
@ 2017-11-22 12:48             ` Jaehoon Chung
  0 siblings, 0 replies; 11+ messages in thread
From: Jaehoon Chung @ 2017-11-22 12:48 UTC (permalink / raw)
  To: u-boot

On 11/22/2017 09:27 PM, Tom Rini wrote:
> On Wed, Nov 22, 2017 at 05:25:02PM +0900, Jaehoon Chung wrote:
>> On 11/20/2017 09:52 PM, Jorge Ramirez wrote:
>>> On 11/10/2017 01:29 PM, Jorge Ramirez wrote:
>>>> On 11/07/2017 11:48 PM, Tom Rini wrote:
>>>>> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>>>>>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>>>>>> Hey all,
>>>>>>>
>>>>>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>>>>>> day.  Please let me know if you know of any regressions, thanks!
>>>>>> Hi Tom,
>>>>>>
>>>>>> emmc accesses are broken for dragonboard410c
>>>>>> I posted the fix [1] last week. will you merge it?
>>>>
>>>> just changed the email subject
>>>>
>>>>> [1] is: https://patchwork.ozlabs.org/patch/833376/
>>>>>
>>>>> Jaehoon, are you OK with this patch?  Thanks!
>>>>>
>>>>
>>>
>>> a ping on this matter - as the db410c maintainer a quick reminder that the emmc support remains broken until this (above [1]) (or an alternative fix) is merged.
>>
>> I sent the email to Tom about 1 weeks ago..if it doesn't apply yet, i will pick it..
>> Maybe i had replied with the my gmail account, something missed.
> 
> Yeah, I missed that, sorry.  Please put together a pull request of all
> the various outstanding MMC changes ASAP, thanks!

Thanks for checking! I will send PR with all.!

Best Regards,
Jaehoon Chung

> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2017-11-20 12:52       ` Jorge Ramirez
  2017-11-22  8:25         ` Jaehoon Chung
@ 2018-01-09  9:48         ` Jorge Ramirez
  2018-01-09 10:03           ` Jorge Ramirez
  1 sibling, 1 reply; 11+ messages in thread
From: Jorge Ramirez @ 2018-01-09  9:48 UTC (permalink / raw)
  To: u-boot

On 11/20/2017 01:52 PM, Jorge Ramirez wrote:
> On 11/10/2017 01:29 PM, Jorge Ramirez wrote:
>> On 11/07/2017 11:48 PM, Tom Rini wrote:
>>> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>>>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>>>> Hey all,
>>>>>
>>>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>>>> day.  Please let me know if you know of any regressions, thanks!
>>>> Hi Tom,
>>>>
>>>> emmc accesses are broken for dragonboard410c
>>>> I posted the fix [1] last week. will you merge it?
>>
>> just changed the email subject
>>
>>> [1] is: https://patchwork.ozlabs.org/patch/833376/
>>>
>>> Jaehoon, are you OK with this patch?  Thanks!
>>>
>>
>
> a ping on this matter - as the db410c maintainer a quick reminder that 
> the emmc support remains broken until this (above [1]) (or an 
> alternative fix) is merged.

ping again :)

I can see the patch in 
http://git.denx.de/?p=u-boot/u-boot-mmc.git;a=commit;h=c7e47ab0aa98da76824b6fa166fb02cfaa7284ad 
so I am hoping it will be merged in this cycle?
This fix was submitted at the end of October to allow db410c users 
access to the emmc (fix a regression)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] sdhci - review?
  2018-01-09  9:48         ` Jorge Ramirez
@ 2018-01-09 10:03           ` Jorge Ramirez
  0 siblings, 0 replies; 11+ messages in thread
From: Jorge Ramirez @ 2018-01-09 10:03 UTC (permalink / raw)
  To: u-boot

On 01/09/2018 10:48 AM, Jorge Ramirez wrote:
> On 11/20/2017 01:52 PM, Jorge Ramirez wrote:
>> On 11/10/2017 01:29 PM, Jorge Ramirez wrote:
>>> On 11/07/2017 11:48 PM, Tom Rini wrote:
>>>> On Tue, Nov 07, 2017 at 08:13:02AM +0100, Jorge Ramirez wrote:
>>>>> On 11/07/2017 12:28 AM, Tom Rini wrote:
>>>>>> Hey all,
>>>>>>
>>>>>> It's release day and v2017.11-rc4 is out.  It's a week until release
>>>>>> day.  Please let me know if you know of any regressions, thanks!
>>>>> Hi Tom,
>>>>>
>>>>> emmc accesses are broken for dragonboard410c
>>>>> I posted the fix [1] last week. will you merge it?
>>>
>>> just changed the email subject
>>>
>>>> [1] is: https://patchwork.ozlabs.org/patch/833376/
>>>>
>>>> Jaehoon, are you OK with this patch?  Thanks!
>>>>
>>>
>>
>> a ping on this matter - as the db410c maintainer a quick reminder 
>> that the emmc support remains broken until this (above [1]) (or an 
>> alternative fix) is merged.
>
> ping again :)
>
> I can see the patch in 
> http://git.denx.de/?p=u-boot/u-boot-mmc.git;a=commit;h=c7e47ab0aa98da76824b6fa166fb02cfaa7284ad 
> so I am hoping it will be merged in this cycle?
> This fix was submitted at the end of October to allow db410c users 
> access to the emmc (fix a regression)

please ignore. I can see it in u-boot/next.

TIA

>
>
>
>
>
>
>
>
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-01-09 10:03 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 23:28 [U-Boot] [ANN] U-Boot v2017.11-rc4 released Tom Rini
2017-11-07  7:13 ` Jorge Ramirez
2017-11-07 22:48   ` Tom Rini
2017-11-10 12:29     ` [U-Boot] sdhci - review? Jorge Ramirez
2017-11-20 12:52       ` Jorge Ramirez
2017-11-22  8:25         ` Jaehoon Chung
2017-11-22 12:27           ` Tom Rini
2017-11-22 12:48             ` Jaehoon Chung
2018-01-09  9:48         ` Jorge Ramirez
2018-01-09 10:03           ` Jorge Ramirez
2017-11-16 12:31     ` [U-Boot] [ANN] U-Boot v2017.11-rc4 released Jaehoon Chung

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox