U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc
Date: Mon, 12 Feb 2018 16:39:15 +0100	[thread overview]
Message-ID: <20180212163915.55d87feb@jawa> (raw)
In-Reply-To: <5c3a2593-62a1-054a-9c13-9f64dbe04973@denx.de>

Hi Simon, Marek,

> On 02/12/2018 04:16 PM, Simon Goldschmidt wrote:
> > On 12.02.2018 15:54, Marek Vasut wrote:  
> >> On 02/12/2018 03:52 PM, Simon Goldschmidt wrote:  
> >>> In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some
> >>> thins for spi flash and mmc that are not required by the hw.  
> >> things ?
> >>
> >> what hw, all supported boards you mean ?
> >>  
> >>> Give users more freedom of choice and use imply here instead
> >>> of select.
> >>>
> >>> This should allow disabling spi support completely or using
> >>> sd/mmc boot in "raw mode" (no partitions).  
> >> You can just turn them off in the defconfigs, but I get what you're
> >> trying to say.
> >>
> >> Just reword the commit message and do make savedefconfig for all
> >> the socfpga platforms (in a separate patch) to sync the defconfigs
> >> up.  
> > 
> > OK, thanks. Given that the same files are touched, should I wait
> > for the CONFIG_HW_WATCHDOG patches from Lukasz to be applied
> > first?  
> 
> You two figure it out :)

It is always better to ask socfpga veteran for his opinion :-)

> 

Simon, feel free to perform the clean up. I will have to look more
closely to the WDT move to Kconfig.

Even better, you are more than welcome to use/squash this patch to your
work:
http://patchwork.ozlabs.org/patch/871578/

It will simplify my WDT conversion work.

Thanks for help.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/85ca4e8b/attachment.sig>

  reply	other threads:[~2018-02-12 15:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 14:52 [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc Simon Goldschmidt
2018-02-12 14:54 ` Marek Vasut
2018-02-12 15:16   ` Simon Goldschmidt
2018-02-12 15:23     ` Marek Vasut
2018-02-12 15:39       ` Lukasz Majewski [this message]
2018-02-12 15:40         ` Marek Vasut
2018-02-12 16:46   ` Tom Rini
2018-02-12 16:51     ` Marek Vasut
2018-02-12 16:53       ` Tom Rini
2018-02-13 12:33   ` Simon Goldschmidt
2018-02-13 12:37     ` Marek Vasut
2018-02-13 12:41       ` Simon Goldschmidt
2018-02-13 12:44         ` Marek Vasut
2018-02-13 12:46           ` Simon Goldschmidt
2018-02-13 12:50             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212163915.55d87feb@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox