From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc
Date: Mon, 12 Feb 2018 11:53:09 -0500 [thread overview]
Message-ID: <20180212165309.GE10592@bill-the-cat> (raw)
In-Reply-To: <307782fd-e2dd-8bf6-9147-a860e04e7b47@denx.de>
On Mon, Feb 12, 2018 at 05:51:08PM +0100, Marek Vasut wrote:
> On 02/12/2018 05:46 PM, Tom Rini wrote:
> > On Mon, Feb 12, 2018 at 03:54:13PM +0100, Marek Vasut wrote:
> >> On 02/12/2018 03:52 PM, Simon Goldschmidt wrote:
> >>> In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some
> >>> thins for spi flash and mmc that are not required by the hw.
> >>
> >> things ?
> >>
> >> what hw, all supported boards you mean ?
> >>
> >>> Give users more freedom of choice and use imply here instead
> >>> of select.
> >>>
> >>> This should allow disabling spi support completely or using
> >>> sd/mmc boot in "raw mode" (no partitions).
> >>
> >> You can just turn them off in the defconfigs, but I get what you're
> >> trying to say.
> >
> > Well, hold on. If you have select FOO under ARCH_xxx then you
> > can't disable it. You have to use imply FOO under ARCH_xxx so that it's
> > turned on by default but a board can disable it in their defconfig.
> > Thanks!
>
> The patch is using imply already ...
Right. I wasn't clear if you were saying it wasn't needed, or just to
re-word things a lot :)
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/16e74525/attachment.sig>
next prev parent reply other threads:[~2018-02-12 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 14:52 [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc Simon Goldschmidt
2018-02-12 14:54 ` Marek Vasut
2018-02-12 15:16 ` Simon Goldschmidt
2018-02-12 15:23 ` Marek Vasut
2018-02-12 15:39 ` Lukasz Majewski
2018-02-12 15:40 ` Marek Vasut
2018-02-12 16:46 ` Tom Rini
2018-02-12 16:51 ` Marek Vasut
2018-02-12 16:53 ` Tom Rini [this message]
2018-02-13 12:33 ` Simon Goldschmidt
2018-02-13 12:37 ` Marek Vasut
2018-02-13 12:41 ` Simon Goldschmidt
2018-02-13 12:44 ` Marek Vasut
2018-02-13 12:46 ` Simon Goldschmidt
2018-02-13 12:50 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212165309.GE10592@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox