From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined
Date: Sat, 24 Feb 2018 18:00:21 -0500 [thread overview]
Message-ID: <20180224230021.GS4311@bill-the-cat> (raw)
In-Reply-To: <262b5073-323d-e94b-33f9-be58ba5dcb91@gmail.com>
On Sat, Feb 24, 2018 at 08:49:38PM +0100, Marek Vasut wrote:
> On 02/24/2018 08:15 PM, Tom Rini wrote:
> > On Sat, Feb 24, 2018 at 12:24:17PM +0100, Marek Vasut wrote:
> >
> >> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
> >>
> >> The u-boot-elf.srec is needed for some platforms, conveniently generate this file.
> >>
> >> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> >> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >> Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> >> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> >> ---
> >> Makefile | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index 57cb4b87d9..cd464c0e69 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -792,7 +792,7 @@ ALL-$(CONFIG_OF_HOSTFILE) += u-boot.dtb
> >> ifneq ($(CONFIG_SPL_TARGET),)
> >> ALL-$(CONFIG_SPL) += $(CONFIG_SPL_TARGET:"%"=%)
> >> endif
> >> -ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf
> >> +ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf u-boot-elf.srec
> >> ALL-$(CONFIG_EFI_APP) += u-boot-app.efi
> >> ALL-$(CONFIG_EFI_STUB) += u-boot-payload.efi
> >>
> >> @@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
> >> u-boot.hex u-boot.srec: u-boot FORCE
> >> $(call if_changed,objcopy)
> >>
> >> +OBJCOPYFLAGS_u-boot-elf.srec := $(OBJCOPYFLAGS_u-boot.srec)
> >> +
> >> +u-boot-elf.srec: u-boot.elf FORCE
> >> + $(call if_changed,objcopy)
> >> +
> >> OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
> >> $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
> >
> > Do we really need the first hunk here, esp given that in 2/2 we make use
> > of CONFIG_BUILD_TARGET to say that we need to build u-boot-elf.srec?
>
> Probably not, but then we can very well convert platforms using
> REMAKE_ELF to CONFIG_BUILD_TARGET too ?
We quite possibly could do that as well, as part of migration of
BUILD_TARGET to Kconfig.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180224/df57bd16/attachment.sig>
prev parent reply other threads:[~2018-02-24 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 11:24 [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Marek Vasut
2018-02-24 11:24 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3 Marek Vasut
2018-02-24 19:16 ` Tom Rini
2018-02-24 19:50 ` Marek Vasut
2018-02-24 19:15 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Tom Rini
2018-02-24 19:49 ` Marek Vasut
2018-02-24 23:00 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224230021.GS4311@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox