* [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined
@ 2018-02-24 11:24 Marek Vasut
2018-02-24 11:24 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3 Marek Vasut
2018-02-24 19:15 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Tom Rini
0 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2018-02-24 11:24 UTC (permalink / raw)
To: u-boot
From: Masaru Nagai <masaru.nagai.vx@renesas.com>
The u-boot-elf.srec is needed for some platforms, conveniently generate this file.
Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
Makefile | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 57cb4b87d9..cd464c0e69 100644
--- a/Makefile
+++ b/Makefile
@@ -792,7 +792,7 @@ ALL-$(CONFIG_OF_HOSTFILE) += u-boot.dtb
ifneq ($(CONFIG_SPL_TARGET),)
ALL-$(CONFIG_SPL) += $(CONFIG_SPL_TARGET:"%"=%)
endif
-ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf
+ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf u-boot-elf.srec
ALL-$(CONFIG_EFI_APP) += u-boot-app.efi
ALL-$(CONFIG_EFI_STUB) += u-boot-payload.efi
@@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
u-boot.hex u-boot.srec: u-boot FORCE
$(call if_changed,objcopy)
+OBJCOPYFLAGS_u-boot-elf.srec := $(OBJCOPYFLAGS_u-boot.srec)
+
+u-boot-elf.srec: u-boot.elf FORCE
+ $(call if_changed,objcopy)
+
OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
$(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
--
2.16.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3
2018-02-24 11:24 [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Marek Vasut
@ 2018-02-24 11:24 ` Marek Vasut
2018-02-24 19:16 ` Tom Rini
2018-02-24 19:15 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Tom Rini
1 sibling, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-02-24 11:24 UTC (permalink / raw)
To: u-boot
From: Masaru Nagai <masaru.nagai.vx@renesas.com>
The u-boot-elf.srec is needed for the minimon update on Gen3 SoCs,
conveniently generate this file.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
include/configs/rcar-gen3-common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/rcar-gen3-common.h b/include/configs/rcar-gen3-common.h
index 226069d67c..d665caf274 100644
--- a/include/configs/rcar-gen3-common.h
+++ b/include/configs/rcar-gen3-common.h
@@ -13,6 +13,7 @@
#include <asm/arch/rmobile.h>
#define CONFIG_REMAKE_ELF
+#define CONFIG_BUILD_TARGET "u-boot-elf.srec"
/* boot option */
#define CONFIG_SUPPORT_RAW_INITRD
--
2.16.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3
2018-02-24 11:24 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3 Marek Vasut
@ 2018-02-24 19:16 ` Tom Rini
2018-02-24 19:50 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-02-24 19:16 UTC (permalink / raw)
To: u-boot
On Sat, Feb 24, 2018 at 12:24:18PM +0100, Marek Vasut wrote:
> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>
> The u-boot-elf.srec is needed for the minimon update on Gen3 SoCs,
> conveniently generate this file.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
> include/configs/rcar-gen3-common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/rcar-gen3-common.h b/include/configs/rcar-gen3-common.h
> index 226069d67c..d665caf274 100644
> --- a/include/configs/rcar-gen3-common.h
> +++ b/include/configs/rcar-gen3-common.h
> @@ -13,6 +13,7 @@
> #include <asm/arch/rmobile.h>
>
> #define CONFIG_REMAKE_ELF
> +#define CONFIG_BUILD_TARGET "u-boot-elf.srec"
>
> /* boot option */
> #define CONFIG_SUPPORT_RAW_INITRD
As is, this is fine. But, there's a small number of CONFIG_BUILD_TARGET
platforms, can you take a pass at Kconfig conversion (and you should be
able to say default "u-boot-elf.srec" if RCAR_GEN3, default "u-boot.itb"
if ARCH_SUNXI, etc, for the few users we have currently. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180224/0be718fb/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3
2018-02-24 19:16 ` Tom Rini
@ 2018-02-24 19:50 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2018-02-24 19:50 UTC (permalink / raw)
To: u-boot
On 02/24/2018 08:16 PM, Tom Rini wrote:
> On Sat, Feb 24, 2018 at 12:24:18PM +0100, Marek Vasut wrote:
>
>> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>
>> The u-boot-elf.srec is needed for the minimon update on Gen3 SoCs,
>> conveniently generate this file.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>> include/configs/rcar-gen3-common.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/rcar-gen3-common.h b/include/configs/rcar-gen3-common.h
>> index 226069d67c..d665caf274 100644
>> --- a/include/configs/rcar-gen3-common.h
>> +++ b/include/configs/rcar-gen3-common.h
>> @@ -13,6 +13,7 @@
>> #include <asm/arch/rmobile.h>
>>
>> #define CONFIG_REMAKE_ELF
>> +#define CONFIG_BUILD_TARGET "u-boot-elf.srec"
>>
>> /* boot option */
>> #define CONFIG_SUPPORT_RAW_INITRD
>
> As is, this is fine. But, there's a small number of CONFIG_BUILD_TARGET
> platforms, can you take a pass at Kconfig conversion (and you should be
> able to say default "u-boot-elf.srec" if RCAR_GEN3, default "u-boot.itb"
> if ARCH_SUNXI, etc, for the few users we have currently. Thanks!
After 2018.03 release though, I don't want to break the current one for
anyone.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined
2018-02-24 11:24 [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Marek Vasut
2018-02-24 11:24 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3 Marek Vasut
@ 2018-02-24 19:15 ` Tom Rini
2018-02-24 19:49 ` Marek Vasut
1 sibling, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-02-24 19:15 UTC (permalink / raw)
To: u-boot
On Sat, Feb 24, 2018 at 12:24:17PM +0100, Marek Vasut wrote:
> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>
> The u-boot-elf.srec is needed for some platforms, conveniently generate this file.
>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
> Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 57cb4b87d9..cd464c0e69 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -792,7 +792,7 @@ ALL-$(CONFIG_OF_HOSTFILE) += u-boot.dtb
> ifneq ($(CONFIG_SPL_TARGET),)
> ALL-$(CONFIG_SPL) += $(CONFIG_SPL_TARGET:"%"=%)
> endif
> -ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf
> +ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf u-boot-elf.srec
> ALL-$(CONFIG_EFI_APP) += u-boot-app.efi
> ALL-$(CONFIG_EFI_STUB) += u-boot-payload.efi
>
> @@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
> u-boot.hex u-boot.srec: u-boot FORCE
> $(call if_changed,objcopy)
>
> +OBJCOPYFLAGS_u-boot-elf.srec := $(OBJCOPYFLAGS_u-boot.srec)
> +
> +u-boot-elf.srec: u-boot.elf FORCE
> + $(call if_changed,objcopy)
> +
> OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
> $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
Do we really need the first hunk here, esp given that in 2/2 we make use
of CONFIG_BUILD_TARGET to say that we need to build u-boot-elf.srec?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180224/824e82af/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined
2018-02-24 19:15 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Tom Rini
@ 2018-02-24 19:49 ` Marek Vasut
2018-02-24 23:00 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-02-24 19:49 UTC (permalink / raw)
To: u-boot
On 02/24/2018 08:15 PM, Tom Rini wrote:
> On Sat, Feb 24, 2018 at 12:24:17PM +0100, Marek Vasut wrote:
>
>> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>
>> The u-boot-elf.srec is needed for some platforms, conveniently generate this file.
>>
>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>> Makefile | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 57cb4b87d9..cd464c0e69 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -792,7 +792,7 @@ ALL-$(CONFIG_OF_HOSTFILE) += u-boot.dtb
>> ifneq ($(CONFIG_SPL_TARGET),)
>> ALL-$(CONFIG_SPL) += $(CONFIG_SPL_TARGET:"%"=%)
>> endif
>> -ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf
>> +ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf u-boot-elf.srec
>> ALL-$(CONFIG_EFI_APP) += u-boot-app.efi
>> ALL-$(CONFIG_EFI_STUB) += u-boot-payload.efi
>>
>> @@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
>> u-boot.hex u-boot.srec: u-boot FORCE
>> $(call if_changed,objcopy)
>>
>> +OBJCOPYFLAGS_u-boot-elf.srec := $(OBJCOPYFLAGS_u-boot.srec)
>> +
>> +u-boot-elf.srec: u-boot.elf FORCE
>> + $(call if_changed,objcopy)
>> +
>> OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
>> $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
>
> Do we really need the first hunk here, esp given that in 2/2 we make use
> of CONFIG_BUILD_TARGET to say that we need to build u-boot-elf.srec?
Probably not, but then we can very well convert platforms using
REMAKE_ELF to CONFIG_BUILD_TARGET too ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined
2018-02-24 19:49 ` Marek Vasut
@ 2018-02-24 23:00 ` Tom Rini
0 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-24 23:00 UTC (permalink / raw)
To: u-boot
On Sat, Feb 24, 2018 at 08:49:38PM +0100, Marek Vasut wrote:
> On 02/24/2018 08:15 PM, Tom Rini wrote:
> > On Sat, Feb 24, 2018 at 12:24:17PM +0100, Marek Vasut wrote:
> >
> >> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
> >>
> >> The u-boot-elf.srec is needed for some platforms, conveniently generate this file.
> >>
> >> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> >> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >> Cc: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> >> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> >> ---
> >> Makefile | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index 57cb4b87d9..cd464c0e69 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -792,7 +792,7 @@ ALL-$(CONFIG_OF_HOSTFILE) += u-boot.dtb
> >> ifneq ($(CONFIG_SPL_TARGET),)
> >> ALL-$(CONFIG_SPL) += $(CONFIG_SPL_TARGET:"%"=%)
> >> endif
> >> -ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf
> >> +ALL-$(CONFIG_REMAKE_ELF) += u-boot.elf u-boot-elf.srec
> >> ALL-$(CONFIG_EFI_APP) += u-boot-app.efi
> >> ALL-$(CONFIG_EFI_STUB) += u-boot-payload.efi
> >>
> >> @@ -926,6 +926,11 @@ OBJCOPYFLAGS_u-boot.srec := -O srec
> >> u-boot.hex u-boot.srec: u-boot FORCE
> >> $(call if_changed,objcopy)
> >>
> >> +OBJCOPYFLAGS_u-boot-elf.srec := $(OBJCOPYFLAGS_u-boot.srec)
> >> +
> >> +u-boot-elf.srec: u-boot.elf FORCE
> >> + $(call if_changed,objcopy)
> >> +
> >> OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
> >> $(if $(CONFIG_X86_16BIT_INIT),-R .start16 -R .resetvec)
> >
> > Do we really need the first hunk here, esp given that in 2/2 we make use
> > of CONFIG_BUILD_TARGET to say that we need to build u-boot-elf.srec?
>
> Probably not, but then we can very well convert platforms using
> REMAKE_ELF to CONFIG_BUILD_TARGET too ?
We quite possibly could do that as well, as part of migration of
BUILD_TARGET to Kconfig.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180224/df57bd16/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-24 23:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-24 11:24 [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Marek Vasut
2018-02-24 11:24 ` [U-Boot] [PATCH 2/2] ARM: rmobile: Build u-boot-elf.srec on Gen3 Marek Vasut
2018-02-24 19:16 ` Tom Rini
2018-02-24 19:50 ` Marek Vasut
2018-02-24 19:15 ` [U-Boot] [PATCH 1/2] Makefile: add u-boot-elf.srec if CONFIG_REMAKE_ELF is defined Tom Rini
2018-02-24 19:49 ` Marek Vasut
2018-02-24 23:00 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox