public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] davinci: omapl138_lcdk: fix PLL0 frequency
Date: Thu, 22 Mar 2018 16:35:02 -0400	[thread overview]
Message-ID: <20180322203502.GK4759@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <1521077790-17411-1-git-send-email-david@lechnology.com>

On Wed, Mar 14, 2018 at 08:36:30PM -0500, David Lechner wrote:

> commit 1601dd97edc6 ("davinci: omapl138_lcdk: increase PLL0 frequency")
> changed the PLL0 frequency to 456MHz, which is needed for the LCDC IP
> block. However, in doing so, it caused the PLLOUT clock to be outside
> of the allowable specifications given in the OMAP-L138 data sheet. (It
> says PLLOUT must be 600MHz max). It also uses a PLLM value outside of
> the range given in the TRM (it says PLLM must in the range 0 to 0x1f).
> 
> So here is what we have currently:
> 
> PLLOUT = 24 / (0 + 1) * (37 + 1) = 912MHz (out of spec)
>          ^     ^         ^
>        CLKIN PREDIV    PLLM (out of spec)
> 
> input to PLLDIVn = 912 / (1 + 1) = 456MHz (desired result)
>                     ^     ^
>                  PLLOUT POSTDIV
> 
> This changes the PLLM value to 18 and the POSTDIV value to 0 so that
> PLLOUT is now within specification but we still get the desired
> result.
> 
> PLLOUT = 24 / (0 + 1) * (18 + 1) = 456MHz (within spec)
>          ^     ^         ^
>        CLKIN PREDIV     PLLM
> 
> input to PLLDIVn = 456 / (0 + 1) = 456MHz (desired result)
>                     ^     ^
>                  PLLOUT POSTDIV
> 
> Fixes: 1601dd97edc6 ("davinci: omapl138_lcdk: increase PLL0 frequency")
> Signed-off-by: David Lechner <david@lechnology.com>
> Reported-by: Sekhar Nori <nsekhar@ti.com>
> Tested-by: Sekhar Nori <nsekhar@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180322/74182e42/attachment.sig>

      parent reply	other threads:[~2018-03-22 20:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15  1:36 [U-Boot] [PATCH] davinci: omapl138_lcdk: fix PLL0 frequency David Lechner
2018-03-15 10:39 ` Peter Howard
2018-03-15 12:34 ` Sekhar Nori
2018-03-15 13:42   ` Sekhar Nori
2018-03-15 14:31     ` Sekhar Nori
2018-03-15 14:56       ` Tom Rini
2018-03-15 15:02         ` David Lechner
2018-03-16  8:04           ` Sekhar Nori
2018-03-15 15:01       ` Lokesh Vutla
2018-03-16  7:51         ` Sekhar Nori
2018-03-15 14:32   ` David Lechner
2018-03-16  9:26     ` Sekhar Nori
2018-03-16 15:45       ` David Lechner
2018-03-18  4:21         ` Peter Howard
2018-03-18  4:22         ` Peter Howard
2018-03-16  6:26 ` Mike Looijmans
2018-03-16 15:56   ` David Lechner
2018-03-18 18:26     ` Mike Looijmans
2018-03-18  4:12 ` Peter Howard
2018-03-22 20:35 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322203502.GK4759@bill-the-cat.ec.rr.com \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox