From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/3] net: Sanitize DHCP variable override
Date: Thu, 14 Jun 2018 12:04:23 +0200 [thread overview]
Message-ID: <20180614100426.40511-1-agraf@suse.de> (raw)
While trying to boot from network on a RISC-V AX25 platform, I saw
that the DHCP IP address did not get populated from the DHCP server
IP address. The reason for that was simple: CONFIG_BOOTP_SERVERIP
was set.
I don't know the history of that option, but it seems to decrease
intuitivity levels of the dhcp command rather than improve it.
What I usually would expect is that explicitly set values populate
through all layers. So if I set a TFTP file name, it populates. If
I set a target IP address, it populates. If I don't set anything,
the values get filled in automatically.
This patch set is trying to move us into that direction without
breaking people that rely on the existing behavior. With this patch
set applied, boards have the option to prefer the 'serverip'
environment variable (ax25-ae350 gets moved to it) over the DHCP
given address and any value explicitly set on the command line is
always preferred.
This hopefully makes the command line a bit more intuitive.
v1 -> v2:
- new patch: net: Prefer command line arguments
- remove README entry
- improve Kconfig help texts
Alexander Graf (3):
net: Prefer command line arguments
net: Add option to prefer bootp/dhcp serverip
ax25: Switch to CONFIG_BOOTP_PREFER_SERVERIP
cmd/Kconfig | 11 +++++++++++
cmd/net.c | 10 ++++++++--
configs/ax25-ae350_defconfig | 1 +
include/configs/ax25-ae350.h | 1 -
include/net.h | 2 ++
net/bootp.c | 10 ++++++++--
net/net.c | 2 ++
7 files changed, 32 insertions(+), 5 deletions(-)
--
2.12.3
next reply other threads:[~2018-06-14 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 10:04 Alexander Graf [this message]
2018-06-14 10:04 ` [U-Boot] [PATCH v2 1/3] net: Prefer command line arguments Alexander Graf
2018-06-14 16:34 ` Joe Hershberger
2018-06-14 10:04 ` [U-Boot] [PATCH v2 2/3] net: Add option to prefer bootp/dhcp serverip Alexander Graf
2018-06-14 16:57 ` Joe Hershberger
2018-06-14 10:04 ` [U-Boot] [PATCH v2 3/3] ax25: Switch to CONFIG_BOOTP_PREFER_SERVERIP Alexander Graf
2018-06-14 16:58 ` Joe Hershberger
2018-06-15 8:24 ` Alexander Graf
2018-06-15 20:08 ` Joe Hershberger
2018-06-15 20:33 ` Alexander Graf
2018-06-15 20:36 ` Joe Hershberger
2018-06-15 20:39 ` Alexander Graf
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3F6B7A657C@ATCPCS16.andestech.com>
2018-06-15 6:12 ` [U-Boot] [PATCH v2 0/3] net: Sanitize DHCP variable override Rick Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614100426.40511-1-agraf@suse.de \
--to=agraf@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox