public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] ax25: Switch to CONFIG_BOOTP_PREFER_SERVERIP
Date: Thu, 14 Jun 2018 12:04:26 +0200	[thread overview]
Message-ID: <20180614100426.40511-4-agraf@suse.de> (raw)
In-Reply-To: <20180614100426.40511-1-agraf@suse.de>

The ax25-ae350 target currently uses CONFIG_BOOTP_SERVERIP which means we
ignore the DHCP provided TFTP ip address. This breaks every case where we
do now provide a serverip environment variable.

Instead, let's use the new CONFIG_BOOT_PREFER_SERVERIP option to fall back
to the DHCP provided TFTP IP if no serverip environment variable is set.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 configs/ax25-ae350_defconfig | 1 +
 include/configs/ax25-ae350.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/ax25-ae350_defconfig b/configs/ax25-ae350_defconfig
index fc04c87485..a328555af6 100644
--- a/configs/ax25-ae350_defconfig
+++ b/configs/ax25-ae350_defconfig
@@ -40,3 +40,4 @@ CONFIG_DM_SPI=y
 CONFIG_ATCSPI200_SPI=y
 CONFIG_TIMER=y
 CONFIG_ATCPIT100_TIMER=y
+CONFIG_BOOTP_PREFER_SERVERIP=y
diff --git a/include/configs/ax25-ae350.h b/include/configs/ax25-ae350.h
index b1ca5ac11a..b230896734 100644
--- a/include/configs/ax25-ae350.h
+++ b/include/configs/ax25-ae350.h
@@ -11,7 +11,6 @@
  * CPU and Board Configuration Options
  */
 #define CONFIG_BOOTP_SEND_HOSTNAME
-#define CONFIG_BOOTP_SERVERIP
 
 /*
  * Miscellaneous configurable options
-- 
2.12.3

  parent reply	other threads:[~2018-06-14 10:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 10:04 [U-Boot] [PATCH v2 0/3] net: Sanitize DHCP variable override Alexander Graf
2018-06-14 10:04 ` [U-Boot] [PATCH v2 1/3] net: Prefer command line arguments Alexander Graf
2018-06-14 16:34   ` Joe Hershberger
2018-06-14 10:04 ` [U-Boot] [PATCH v2 2/3] net: Add option to prefer bootp/dhcp serverip Alexander Graf
2018-06-14 16:57   ` Joe Hershberger
2018-06-14 10:04 ` Alexander Graf [this message]
2018-06-14 16:58   ` [U-Boot] [PATCH v2 3/3] ax25: Switch to CONFIG_BOOTP_PREFER_SERVERIP Joe Hershberger
2018-06-15  8:24     ` Alexander Graf
2018-06-15 20:08       ` Joe Hershberger
2018-06-15 20:33         ` Alexander Graf
2018-06-15 20:36           ` Joe Hershberger
2018-06-15 20:39             ` Alexander Graf
     [not found] ` <752D002CFF5D0F4FA35C0100F1D73F3F6B7A657C@ATCPCS16.andestech.com>
2018-06-15  6:12   ` [U-Boot] [PATCH v2 0/3] net: Sanitize DHCP variable override Rick Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614100426.40511-4-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox