public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lothar Felten <lothar.felten@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 2/6] net: sun8i-emac: fix printing NULL character
Date: Fri, 13 Jul 2018 10:45:26 +0200	[thread overview]
Message-ID: <20180713084530.13029-2-lothar.felten@gmail.com> (raw)
In-Reply-To: <20180713084530.13029-1-lothar.felten@gmail.com>

If the variant is not set and therefore NULL, do not attempt to print
the variant.

Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Jagan Teki <jagan@openedev.com>
Tested-by: Jagan Teki <jagan@openedev.com>

---
 Changelog:
 new in v4
 v4->v5->v6 none
---
 drivers/net/sun8i_emac.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 1f5c630e02..23c4d68f77 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -843,8 +843,7 @@ static int sun8i_emac_eth_ofdata_to_platdata(struct udevice *dev)
 	priv->variant = dev_get_driver_data(dev);
 
 	if (!priv->variant) {
-		printf("%s: Missing variant '%s'\n", __func__,
-		       (char *)priv->variant);
+		printf("%s: Missing variant\n", __func__);
 		return -EINVAL;
 	}
 
-- 
2.14.1

  reply	other threads:[~2018-07-13  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  8:45 [U-Boot] [PATCH v6 1/6] sunxi: R40: add gigabit ethernet clocks Lothar Felten
2018-07-13  8:45 ` Lothar Felten [this message]
2018-07-13  8:45 ` [U-Boot] [PATCH v6 3/6] net: sun8i-emac: set mux and clock by driver data Lothar Felten
2018-07-13  8:45 ` [U-Boot] [PATCH v6 4/6] net: sun8i-emac: support R40 GMAC Lothar Felten
2018-07-13  8:45 ` [U-Boot] [PATCH v6 5/6] sunxi: R40: add gigabit ethernet devicetree node Lothar Felten
2018-07-13  8:45 ` [U-Boot] [PATCH v6 6/6] configs: Bananapi_M2_Ultra: enable gigabit ethernet Lothar Felten
2018-07-13  9:11   ` Maxime Ripard
2018-07-16  7:00   ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713084530.13029-2-lothar.felten@gmail.com \
    --to=lothar.felten@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox